Closed
Bug 1174511
Opened 9 years ago
Closed 9 years ago
Show Required / Optional attendance on meeting invites received from other users
Categories
(Calendar :: E-mail based Scheduling (iTIP/iMIP), enhancement)
Calendar
E-mail based Scheduling (iTIP/iMIP)
Tracking
(Not tracked)
RESOLVED
FIXED
4.7
People
(Reporter: nicoschl, Assigned: MakeMyDay)
References
Details
Attachments
(3 files, 3 obsolete files)
Hi,
Could the
Invite Attendees.jpg - Invitation dialog showing one required and one optional attendee
Reporter | ||
Comment 1•9 years ago
|
||
Invitation dialog showing one required and one optional attendee
Attachment #8622055 -
Attachment is obsolete: true
Reporter | ||
Comment 2•9 years ago
|
||
The invite received via email showing the requested attendees.
Reporter | ||
Comment 3•9 years ago
|
||
Sorry about, the unfinished bug description :-(
Hi,
Could the optional attendees be indicated on the user interface when receiving an invite for optional attendance - see attachment - "Received email invitation.jpg"
Here is the relevant data from the .ics with ROLE=OPT-PARTICIPANT
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=OPT-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
TRUE;CN=Nico Schlebusch;X-NUM-GUESTS=0:mailto:nico@slash[removed]
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
TRUE;CN=Nico Schlebusch;X-NUM-GUESTS=0:mailto:nico@apace[removed]
Please let me know if you need more information.
Nico
Assignee | ||
Comment 4•9 years ago
|
||
I was sure we had already a bug for this, but I actually cannot find it, so confirming. We can take care of that once the patch for bug 533265 has been pushed. Needinfo=me to keep track of that.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(makemyday)
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(makemyday)
Version: unspecified → Trunk
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(makemyday)
Assignee | ||
Updated•9 years ago
|
Assignee | ||
Comment 5•9 years ago
|
||
I have a patch for this based on our current icon set from the FB dialog displaying role, user type and partstat side by side left to the attendee.
If possible, I would prefer a single combined icon instead, but that would require somebody else to craft the icons, as I'm not too gifted with such stuff. For that, I have filed bug 1197623.
I'm waiting with requesting review for the patch at least until there has been some feedback on that bug.
Assignee | ||
Comment 6•9 years ago
|
||
This patch requires the patch for the new icons from bug 1197623.
I'd like to get some feedback foremost on the approaches to integrate the svg image in the css file and the localization. As already mentioned in bug 1197623, referencing the fragment identifiers does not work for some reason, so I used the positioning. Alternatively, referencing by calendar-itip-icons.svg#viewBox(...) might work, but I didn't test that.
There is a known issue if you receive an invitation conatining an attendee with multiple delegated-from/delegated-to params for ical.js. The backend gets confused by the multiple comma separated quoted strings, so the attendee id gets not extracted correctly (Libical also does not process that correctly, but ignores all further references but the first and handles the attendee gracefully by that). But this worth a separate bug.
Attachment #8651539 -
Attachment is obsolete: true
Attachment #8663404 -
Flags: feedback?(richard.marti)
Attachment #8663404 -
Flags: feedback?(philipp)
Assignee | ||
Comment 7•9 years ago
|
||
One more thing: I still plan to add some unit tests for ltnInvitationUtil.jsm to patch befor asking for review.
Comment 8•9 years ago
|
||
Comment on attachment 8663404 [details] [diff] [review]
DisplayReqOptParticipantsInPreview-V2.diff
This looks really good. And nice how you are using the variables for the positioning.
What about adding the tooltip on the whole line instead of only the icon? Then the user has not to point directly on the small icon. And the info is also handy when it's shown on the address.
Attachment #8663404 -
Flags: feedback?(richard.marti) → feedback+
Comment 9•9 years ago
|
||
Comment on attachment 8663404 [details] [diff] [review]
DisplayReqOptParticipantsInPreview-V2.diff
Review of attachment 8663404 [details] [diff] [review]:
-----------------------------------------------------------------
Aside from maybe using a more verbose name (--itip-icon-partstat?) I think this is a great approach, sorry for the delay!
Attachment #8663404 -
Flags: feedback?(philipp) → feedback+
Assignee | ||
Comment 10•9 years ago
|
||
Updated patch with comments considered. Additionally, I decoupled the dependency from bug 1225779 and a test.
Attachment #8663404 -
Attachment is obsolete: true
Attachment #8692990 -
Flags: review?(philipp)
Assignee | ||
Comment 11•9 years ago
|
||
Wrong reference - removed dependencies to bugs 1206502 and 1206503.
Comment 12•9 years ago
|
||
Comment on attachment 8692990 [details] [diff] [review]
DisplayReqOptParticipantsInPreview-V3.diff
Review of attachment 8692990 [details] [diff] [review]:
-----------------------------------------------------------------
Whitespaces again. Also, is it possible to use something more specific/named instead of e.g. childNodes[0] ? Maybe querySelector could help here.
Attachment #8692990 -
Flags: review?(philipp) → review+
Assignee | ||
Comment 13•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.7
Comment 14•9 years ago
|
||
Typo in patch: RESSOURCE --> RESOURCE
Assignee | ||
Comment 15•9 years ago
|
||
Alfred, thanks for catching this. I've filed bug 1235355 for this.
You need to log in
before you can comment on or make changes to this bug.
Description
•