Closed
Bug 1174673
Opened 9 years ago
Closed 9 years ago
[RIL] Automatically resume a remaining held call or held conference
Categories
(Firefox OS Graveyard :: RIL, defect)
Tracking
(blocking-b2g:2.2+, firefox40 wontfix, firefox41 wontfix, firefox42 fixed, b2g-v2.2 fixed, b2g-master fixed)
People
(Reporter: hsinyi, Assigned: aknow)
References
Details
Attachments
(4 files)
(deleted),
patch
|
hsinyi
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
hsinyi
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
hsinyi
:
review+
jocheng
:
approval-mozilla-b2g37+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
aknow
:
review+
jocheng
:
approval-mozilla-b2g37+
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Comment 2•9 years ago
|
||
Nominate this as 2.2+ as this blocks a 2.2+ gaia bug 1169409.
blocking-b2g: --- → 2.2?
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(szchen)
QA Contact: szchen
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → szchen
QA Contact: szchen
Assignee | ||
Updated•9 years ago
|
Summary: [RIL] Automatically resume a remaining held call → [RIL] Automatically resume a remaining held call or held conference
Updated•9 years ago
|
blocking-b2g: 2.2? → 2.2+
status-b2g-v2.2:
--- → affected
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8624142 -
Flags: review?(htsai)
Assignee | ||
Comment 4•9 years ago
|
||
Attachment #8624144 -
Flags: review?(htsai)
Reporter | ||
Comment 5•9 years ago
|
||
Comment on attachment 8624142 [details] [diff] [review]
Part 1: Automatically resume the held call
Review of attachment 8624142 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks Aknow.
Attachment #8624142 -
Flags: review?(htsai) → review+
Reporter | ||
Updated•9 years ago
|
Attachment #8624144 -
Flags: review?(htsai) → review+
Assignee | ||
Comment 6•9 years ago
|
||
Comment 9•9 years ago
|
||
Please nominate this for b2g37 approval when you get a chance.
status-b2g-v2.5:
--- → fixed
status-b2g-master:
--- → fixed
status-firefox40:
--- → wontfix
status-firefox41:
--- → wontfix
Flags: needinfo?(szchen)
Target Milestone: --- → FxOS-S2 (10Jul)
Assignee | ||
Comment 10•9 years ago
|
||
Hsinyi,
Due to the difference of code bases, I'd like to have your review again. Thank you.
Flags: needinfo?(szchen)
Attachment #8628696 -
Flags: review?(htsai)
Assignee | ||
Comment 11•9 years ago
|
||
Attachment #8628697 -
Flags: review+
Assignee | ||
Updated•9 years ago
|
Attachment #8628697 -
Attachment description: Part 2: Update test case. r=hsinyi → (2.2) Part 2: Update test case. r=hsinyi
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(szchen)
Reporter | ||
Comment 12•9 years ago
|
||
Comment on attachment 8628696 [details] [diff] [review]
(2.2) Part 1: Automatically resume the held call. r=hsinyi
Review of attachment 8628696 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me, thanks!
Attachment #8628696 -
Flags: review?(htsai) → review+
Assignee | ||
Comment 13•9 years ago
|
||
Comment on attachment 8628696 [details] [diff] [review]
(2.2) Part 1: Automatically resume the held call. r=hsinyi
NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.
[Approval Request Comment]
Bug caused by (feature/regressing bug #): 1169409
User impact if declined: gcf test fail
Testing completed: marionette unit test
Risk to taking this patch (and alternatives if risky): low
String or UUID changes made by this patch: none
Flags: needinfo?(szchen)
Attachment #8628696 -
Flags: approval-mozilla-b2g37?
Assignee | ||
Comment 14•9 years ago
|
||
Comment on attachment 8628697 [details] [diff] [review]
(2.2) Part 2: Update test case. r=hsinyi
NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.
[Approval Request Comment]
Bug caused by (feature/regressing bug #): 1169409
User impact if declined: gcf test fail
Testing completed: marionette unit test
Risk to taking this patch (and alternatives if risky): low
String or UUID changes made by this patch: none
Attachment #8628697 -
Flags: approval-mozilla-b2g37?
Updated•9 years ago
|
Attachment #8628696 -
Flags: approval-mozilla-b2g37? → approval-mozilla-b2g37+
Updated•9 years ago
|
Attachment #8628697 -
Flags: approval-mozilla-b2g37? → approval-mozilla-b2g37+
Comment 15•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/53dee7c7a6d9
https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/581ae0c10df1
Flags: in-testsuite+
Updated•9 years ago
|
status-b2g-v2.5:
fixed → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•