Luís Miguel [:quicksaver] (not reading bugmail) Reporter
	Description • 9 years ago

STR:
1) Open Nightly
2) Open any site
3) Hit " ' " to open Links-Only Quick Find Bar
4) Type anything to find a link
5) Hit Ctrl+Enter

Result: link follows through in the current tab instead of in a new tab.

If you follow these steps in non-e10s firefox, the link is correctly opened in a new tab.

This is because RemoteFinder [1] doesn't send all the modifier properties of the key event that the content script needs [2]. It's only sending .shiftKey, but ideally should also send .ctrlKey, .altKey and .metaKey.

FYI I made that same change [3] in my add-on FindBar Tweak and it seems to work fine.

[1] http://mxr.mozilla.org/mozilla-central/source/toolkit/modules/RemoteFinder.jsm#152
[2] http://mxr.mozilla.org/mozilla-central/source/toolkit/modules/Finder.jsm#257
[3] https://github.com/Quicksaver/FindBar-Tweak/commit/ac1a6947d34b1564d9c48baac713fefcbd13fbf2#diff-a9fb582c55c30fbb12b36558ae975606

	Bill McCloskey [inactive unless it's an emergency] (:billm)
	Comment 1 • 9 years ago

Looks like a dupe.