Closed
Bug 1175305
Opened 9 years ago
Closed 9 years ago
Enable dynamic UA overrides in Fennec (general.useragent.updates.enabled -> true)
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(p11+, firefox41 fixed, fennec41+)
RESOLVED
FIXED
Firefox 41
People
(Reporter: miketaylr, Assigned: miketaylr)
References
Details
(Whiteboard: [compat])
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
miketaylr
:
review+
|
Details | Diff | Splinter Review |
Now that Bug 1163759 is complete, we need to flip the pref to enable UA override updates.
I'd like Bug 1174784 to land first though, so we don't break Youtube when Bug 1169772 lands.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → miket
Blocks: 1169772
tracking-p11:
--- → +
Depends on: 1174784
Whiteboard: [compat]
Assignee | ||
Updated•9 years ago
|
Assignee | ||
Updated•9 years ago
|
tracking-fennec: --- → ?
Assignee | ||
Comment 1•9 years ago
|
||
Margaret, would you mind reviewing?
I've tested that this does in fact talk to our CDN endpoint (https://dynamicua.cdn.mozilla.net/0/%7Baa3c5121-dab2-40e2-81ca-7ea25febc110%7D) and fetches the payload as expected.
Updated•9 years ago
|
tracking-fennec: ? → 41+
Comment 2•9 years ago
|
||
Comment on attachment 8623740 [details] [diff] [review]
1175305-Enable-dynamic-UA-updates-for-Fennec.patch
Review of attachment 8623740 [details] [diff] [review]:
-----------------------------------------------------------------
r+, assuming dependencies land first as needed.
Attachment #8623740 -
Flags: review?(margaret.leibovic) → review+
Assignee | ||
Comment 3•9 years ago
|
||
Updating commit message to reflect r=margaret.
Assignee | ||
Updated•9 years ago
|
Attachment #8623740 -
Attachment is obsolete: true
Assignee | ||
Comment 4•9 years ago
|
||
Sheriffs, no try run because this changeset just flips an existing pref to true (and manual testing looks good).
Keywords: checkin-needed
Keywords: checkin-needed
Comment 6•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Assignee | ||
Updated•9 years ago
|
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•