I was outside the ns firewall, I have a directory in addressbook set up to the netscape phonebook. note, this wasn't from autocomplete prefs, it was because I had a ldap directory set up. problem #1: the prefs says: "when addressing messages, look for matching entries in Local Address Books." we must be autocompleting against all addressbooks, including my hand added prefs for my LDAP addressbook. so the initial fix is to not autocomplete on any non local addressbook. the second issue is how (or if) to merge add / edit / remove directory for autocomplete and the eventual UI we add for add / edit / remove LDAP addressbooks. PR_Lock(PRLock * 0x00000005) line 235 + 3 bytes nsAutoLock::nsAutoLock(PRLock * 0x00000005) line 150 + 13 bytes nsAbQueryLDAPMessageListener::Cancel() line 170 nsAbLDAPDirectoryQuery::StopQuery(nsAbLDAPDirectoryQuery * const 0x068f77e0, int 1) line 629 + 8 bytes nsAbLDAPDirectory::StopSearch(nsAbLDAPDirectory * const 0x068f7838) line 304 + 23 bytes nsAbLDAPDirectory::StartSearch(nsAbLDAPDirectory * const 0x068f7838) line 240 + 12 bytes nsAbLDAPDirectory::GetChildCards(nsAbLDAPDirectory * const 0x068f7778, nsIEnumerator * * 0x0012e500) line 153 + 21 bytes nsAbAutoCompleteSession::SearchCards(nsIAbDirectory * 0x068f7778, nsAbAutoCompleteSearchString * 0x0012e72c, nsIAutoCompleteResults * 0x069130b0) line 384 + 36 bytes nsAbAutoCompleteSession::SearchDirectory(const char * 0x05b8cd10, nsAbAutoCompleteSearchString * 0x0012e72c, nsIAutoCompleteResults * 0x069130b0, int 1) line 489 + 28 bytes nsAbAutoCompleteSession::SearchDirectory(const char * 0x0312c2dc, nsAbAutoCompleteSearchString * 0x0012e72c, nsIAutoCompleteResults * 0x069130b0, int 1) line 512 + 31 bytes nsAbAutoCompleteSession::OnStartLookup(nsAbAutoCompleteSession * const 0x067dfd10, const unsigned short * 0x06915370, nsIAutoCompleteResults * 0x068f6bf0, nsIAutoCompleteListener * 0x06913110) line 628 + 28 bytes XPTC_InvokeByIndex(nsISupports * 0x067dfd10, unsigned int 3, unsigned int 3, nsXPTCVariant * 0x0012e8e8) line 106 XPCWrappedNative::CallMethod(XPCCallContext & {...}, XPCWrappedNative::CallMode CALL_METHOD) line 2009 + 42 bytes XPC_WN_CallMethod(JSContext * 0x057cf5d0, JSObject * 0x03209020, unsigned int 3, long * 0x04e5f1bc, long * 0x0012ebbc) line 1266 + 14 bytes js_Invoke(JSContext * 0x057cf5d0, unsigned int 3, unsigned int 0) line 832 + 23 bytes js_Interpret(JSContext * 0x057cf5d0, long * 0x0012f9ac) line 2798 + 15 bytes js_Invoke(JSContext * 0x057cf5d0, unsigned int 3, unsigned int 2) line 849 + 13 bytes js_InternalInvoke(JSContext * 0x057cf5d0, JSObject * 0x0328d440, long 82372512, unsigned int 0, unsigned int 3, long * 0x068fe8c0, long * 0x0012fad4) line 924 + 20 bytes JS_CallFunctionValue(JSContext * 0x057cf5d0, JSObject * 0x0328d440, long 82372512, unsigned int 3, long * 0x068fe8c0, long * 0x0012fad4) line 3405 + 31 bytes nsJSContext::CallEventHandler(nsJSContext * const 0x057cf780, void * 0x0328d440, void * 0x04e8e7a0, unsigned int 3, void * 0x068fe8c0, int * 0x0012fb6c, int 0) line 1011 + 33 bytes GlobalWindowImpl::RunTimeout(nsTimeoutImpl * 0x068fdd90) line 3838 + 84 bytes GlobalWindowImpl::TimerCallback(nsITimer * 0x068fdb10, void * 0x068fdd90) line 4150 nsTimerImpl::Process() line 233 + 17 bytes handleMyEvent(MyEventType * 0x06906310) line 270 PL_HandleEvent(PLEvent * 0x06906310) line 590 + 10 bytes PL_ProcessPendingEvents(PLEventQueue * 0x0050f600) line 520 + 9 bytes _md_EventReceiverProc(HWND__ * 0x000a023c, unsigned int 49331, unsigned int 0, long 5305856) line 1071 + 9 bytes USER32! 77e13eb0() USER32! 77e1401a() USER32! 77e192da() nsAppShellService::Run(nsAppShellService * const 0x0054fa20) line 303 main1(int 2, char * * 0x00484b90, nsISupports * 0x00000000) line 1264 + 32 bytes main(int 2, char * * 0x00484b90) line 1594 + 37 bytes mainCRTStartup() line 338 + 17 bytes KERNEL32! 77e87903()

p1, since it crashes. for now, I just plan to skip over ldap addressbooks for autocomplete.

Comment on attachment 63150 [details] [diff] [review] same patch, fixed whitespace sr=bienvenu

So should SearchDirectory change its name to SearchLocalDirectory? Presumably, this will also disable autocompleting against Outlook Express abooks; whether or not this is a reasonable thing, I don't know (ie does that work now?). Perhaps John can add his thoughts...

heeding dmose's suggestion, I'm going to add a boolean attribute for autocomplete against. one possible future use for this feature is to make it reflected in per addressbook prefs, so that users could pick and choose which addressbooks we autocomplete against, when autocomplete against local addressbooks is turned on. but for now, it will be false for ldap, true for everything else. when I land the fix, I'll log a bug about the other idea.

Yes, both Outlook and Outlook Express when enabled by manually editing the prefs.js file successfully autocomplete when local address books are included. I can see the need to exclude LDAP Address Books but I would argue that we should continue to ensure that Outlook and Outlook Express are available for auto-completion. I did notice that Outlook and Outlook Express functionality is now broken. The Address Books appear but no data. I first noticed it yesterday. I don't know yet what caused it to break or when but I will log it when I do some more investigation. The other issue raised by the reporter of this bug is the need to have a UI to enable LDAP Address Book. I created a patch some time ago for bug 83091 which attempts to achieve this.

sliding to 0.9.9

This problem is potentially related to bug 79509, though not necessarily.

this needs to be fixed along with the bridge code (bug #83091) if all goes well, this could land during 0.9.8 > I did notice that Outlook and Outlook Express functionality is now broken. The > Address Books appear but no data. I first noticed it yesterday. > I don't know yet what caused it to break or when but I will log it when I do > some more investigation. Probably something I did when I landed the AB_OUTLINER_BRANCH. Sorry John, please cc me on the bug when you log it.

moving to 0.9.9, these aren't 0.9.8 stoppers.

the patch for this will be part of the patch for #83091 I've added this to the nsIAbDirectory interface: + /** + * directory should be used when doing local autocomplete + */ + readonly attribute boolean searchDuringLocalAutocomplete; I've made it so in the base class (nsAbDirProperty) we return true, and for the LDAP subclass (nsAbLDAPDirectory) we return false. this will make it so we'll continue to search outlook and MAPI directories during local autocomplete. eventually, we'll probably extend this to be a getter and setter, and have it reflected into prefs. I imagine at some point, we'll want to add finer control over which local addressbooks they want to autocomplete against (instead of all or nothing).

this been fixed along with 83091

Verified.