Comment on attachment 8623663 [details] [diff] [review] Factor out nsXPCWrappedJSClass::CleanupOutparams Review of attachment 8623663 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/xpconnect/src/XPCWrappedJSClass.cpp @@ +727,5 @@ > + void* p; > + if (!(p = nativeParams[i].val.p)) > + continue; > + > + if (!inOutOnly || param.IsIn()) { Is there actually a reason for the difference in behavior with inOutOnly? I'm fine to keep it, but please comment as to the reason why we need it, or that it's cargo cult. @@ +1194,5 @@ > readyToDoTheCall = true; > > pre_call_clean_up: > // clean up any 'out' params handed in > + CleanupOutparams(cx, methodIndex, info, nativeParams, true, paramCount); Can you add |/* inOutOnly = */|, here and below?

https://hg.mozilla.org/integration/mozilla-inbound/rev/ea5b6a488b42 https://hg.mozilla.org/integration/mozilla-inbound/rev/45e57f3e386b https://hg.mozilla.org/integration/mozilla-inbound/rev/a560e8f99991

https://hg.mozilla.org/mozilla-central/rev/ea5b6a488b42 https://hg.mozilla.org/mozilla-central/rev/45e57f3e386b https://hg.mozilla.org/mozilla-central/rev/a560e8f99991