Closed
Bug 1175605
Opened 9 years ago
Closed 9 years ago
Autophone - webappstartup fails to detect measurements
Categories
(Firefox for Android Graveyard :: Testing, defect)
Firefox for Android Graveyard
Testing
Tracking
(firefox41 fixed, fennec41+)
RESOLVED
FIXED
Firefox 41
People
(Reporter: bc, Assigned: esawin)
References
(Blocks 1 open bug)
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
patch
|
myk
:
review+
|
Details | Diff | Splinter Review |
Beginning with https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=ba34e5e4111a&filter-searchStr=autophone&exclusion_profile=false webappstartup fails to report measurements.
Looks like bug 1171013. esawin: Can we back this out? It is causing me pain.
Reporter | ||
Comment 1•9 years ago
|
||
disabled on everything except try for now.
Comment 2•9 years ago
|
||
Eugen, can you get this back to green?
Component: General → Testing
Flags: needinfo?(esawin)
Reporter | ||
Comment 3•9 years ago
|
||
I did a series of try builds starting before the patch in bug 1171013
See https://treeherder.mozilla.org/#/jobs?repo=try&exclusion_profile=false&filter-searchStr=android&author=bclary@mozilla.com&startdate=2015-06-17&enddate=2015-06-18
The issue really became apparent with the third patch.
https://bug1171013.bugzilla.mozilla.org/attachment.cgi?id=8621564
The nexus 7 is showing partial failures with the run 1 of 8 with the second patch but it is a notoriously flaky device anyway.
Assignee | ||
Comment 4•9 years ago
|
||
The issue is that WebappManager expects the DOMApplicationRegistry to be ready on autoInstall, which is triggered when we try to re-install a webapp from the same location.
I have a patch ready soon, looks good so far: https://treeherder.mozilla.org/#/jobs?repo=try&revision=54f40b1f8e5f&exclusion_profile=false
Flags: needinfo?(esawin)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → esawin
Updated•9 years ago
|
tracking-fennec: ? → 41+
Assignee | ||
Comment 5•9 years ago
|
||
With bug 1171013 we've introduced lazy-loading of Webapps.jsm, so we cannot depend on DOMApplicationRegistry being ready on startup.
This patch ensures that we don't try to auto-update webapps before the registry is loaded and ready.
The change in browser.js is just a precaution, as currently it is safe to call receiveMessage on a non-fully initialized registry.
Attachment #8624350 -
Flags: review?(myk)
Comment 6•9 years ago
|
||
Comment on attachment 8624350 [details] [diff] [review]
0001-Bug-1175605-Do-not-access-DOMApplicationRegistry-pro.patch
Review of attachment 8624350 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good, and it should work correctly, as the lone caller of WebappManager.autoInstall doesn't depend on the timing of the _autoUpdate call.
Attachment #8624350 -
Flags: review?(myk) → review+
Assignee | ||
Comment 7•9 years ago
|
||
Reporter | ||
Comment 9•9 years ago
|
||
That won't actually run the autophone tests. We don't kick off autophone for -u all since most people don't care about autophone until they need to and autophone would suffer a DOS. I'll submit them autophone-webapp for you.
Reporter | ||
Comment 10•9 years ago
|
||
Note you have to show hidden jobs to see autophone:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fee8497a9d9c&filter-searchStr=autophone&exclusion_profile=false
Comment 11•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Assignee | ||
Comment 12•9 years ago
|
||
(In reply to Bob Clary [:bc:] from comment #10)
> Note you have to show hidden jobs to see autophone:
>
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=fee8497a9d9c&filter-
> searchStr=autophone&exclusion_profile=false
Thanks, I assume the 4.3 one is the Nexus 7? I've submitted the autophone results in comment 4.
Reporter | ||
Comment 13•9 years ago
|
||
(In reply to Eugen Sawin [:esawin] from comment #12)
> Thanks, I assume the 4.3 one is the Nexus 7?
Yep. Not sure what is up with that. It was intermittent in the try runs I did last night. We'll see what it does going forward.
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•