Biru Mohanathas [:poiru] Assignee
	Description • 9 years ago

Since bug 1077652, we preload about:privatebrowsing, but we never end up using it because of a check originally added for bug 799495.

	Pulsebot
	Comment 2 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/6a0c6253edc0

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 3 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/6a0c6253edc0

	Biru Mohanathas [:poiru] Assignee
	Comment 4 • 9 years ago

Comment on attachment 8624045 [details] [diff] [review]
Use preloaded about:privatebrowsing page for private new tab pages

Approval Request Comment
[Feature/regressing bug #]: Bug 1118285
[User impact if declined]: Flicker when opening new tab page in a private window. Prior to bug 1118285, one could manually set browser.newtab.url to e.g. about:blank to get rid of the flicker.
[Risks and why]: Minimal risk.
[String/UUID change made/needed]: No.

	Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)
	Comment 5 • 9 years ago

Comment on attachment 8624045 [details] [diff] [review]
Use preloaded about:privatebrowsing page for private new tab pages

Approving for uplift to Aurora. This patch seems safe and has been in m-c for a while now so should be stable.

	Ryan VanderMeulen [:RyanVM]
	Comment 6 • 9 years ago

https://hg.mozilla.org/releases/mozilla-aurora/rev/7bddb842cd1f

	Cody Crews
	Comment 7 • 9 years ago

A screenshot showing that the new tab page is properly loading as about:privatebrowsing after this bug has been resolved.

	Cody Crews
	Comment 8 • 9 years ago

In the above the screenshot, I show that after visiting https://www.google.com in private browsing mode then pressing ctrl+t to open a new tab that the page shown is correct.

	Hossain Al Ikram [:ikram] (QA Contact)
	Comment 9 • 9 years ago

I was trying to test the fix but I am not able to see the bug. Can you please help me understand how I can see the issue so that this can be properly verified!!

I am seeing the same output in 40 beta and Nightly (from 2015-06-17 when the bug was filled) and also the latest one , Nightly 42.0a1! (On Windows 7 , 64 Bit)

	Cody Crews
	Comment 10 • 9 years ago

My understanding of this from looking at the patch was that it should already have a preloaded browser ready for entering into private browsing mode.  The patch takes away part of a conditional that leads to a call to _getPreloadedBrowser which should ensure that anytime you're entering into private browsing mode that this call is attempted.

I probably shouldn't have shown this with a screenshot, as you will get almost the same result visually either way.  That's my fault.  The screenshot does show that new tab page is in fact about:privatebrowsing but can't actually show that the call to _getPreloadedBrowser took place.  There's no real output or any way to show this off except for the fact that it doesn't break anything which is what I encountered here.

Any suggestions or anything different I should do here?

	Biru Mohanathas [:poiru] Assignee
	Comment 11 • 9 years ago

(In reply to Hossain Al Ikram [:ikram] (QA Contact) from comment #9)
> I was trying to test the fix but I am not able to see the bug. Can you
> please help me understand how I can see the issue so that this can be
> properly verified!

Try pressing CTRL+T multiple times in Beta. You should see a flicker as the background color changes from #fbfbfb to #ffffff and back. This happens very quickly so it's easy to miss.