Closed Bug 1176278 Opened 9 years ago Closed 9 years ago

Long strings cause text-chat to be horizontally scrollable

Categories

(Hello (Loop) :: Client, defect, P1)

defect
Points:
1

Tracking

(firefox41 verified)

VERIFIED FIXED
mozilla41
Iteration:
41.3 - Jun 29
Tracking Status
firefox41 --- verified

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

If you have a long string without spaces, e.g. a url, then the text-chat area becomes horizontally scrollable. We need to find a better way of breaking the line.
Flags: firefox-backlog+
This fixes the width of the p wrapper for the entry to 100% i.e. the width of the parent entries box, and at the same time turns on word-wrap for break-word which will break long words or urls only as necessary. This could probably do with an example entry in the ui-showcase, but the one adding the text messages hasn't landed yet, so maybe you could add it to there.
Attachment #8624841 - Flags: review?(dmose)
I only didn't do this earlier, because I hadn't worked out the max-width 100% thing ;-)
Assignee: nobody → standard8
Iteration: --- → 41.3 - Jun 29
Points: --- → 1
Rank: 14
(In reply to Mark Banner (:standard8) from comment #2) > > This could probably do with an example entry in the ui-showcase, but the one > adding the text messages hasn't landed yet, so maybe you could add it to > there. Done. :-)
Comment on attachment 8624841 [details] [diff] [review] Long strings in Loop's text chat cause the chat area to be horizontally scrollable. Review of attachment 8624841 [details] [diff] [review]: ----------------------------------------------------------------- r=dmose The bug that this fixes exists in both Firefox Nightly and Chrome, and this patch fixes it both places. However, the ui-showcase URL that I added in bug 1168848 to surface this error when the code is unpatched, surfaces it in the ui-showcase loaded in Chrome but not the ui-showcase loaded in Firefox! If you could file a spin-off bug on tracking that down, that'd be wonderful.
Attachment #8624841 - Flags: review?(dmose) → review+
(In reply to Dan Mosedale (:dmose) - needinfo? me for response from comment #5) > However, the ui-showcase URL that I added in bug 1168848 to surface this > error when the code is unpatched, surfaces it in the ui-showcase loaded in > Chrome but not the ui-showcase loaded in Firefox! If you could file a > spin-off bug on tracking that down, that'd be wonderful. With the URL, I see the same result on FF for the standalone/conversation window and on the ui-showcase - which is wrapping of the url at punctuation type boundaries. I've therefore tweaked the patch to include an addition to ui-showcase with a long string with no punctuation nor spaces.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Flags: qe-verify+
QA Contact: bogdan.maris
Reproduced the initial issue using old Nightly before the fix. Verified that the strings are wrapped intro the chat bubble and no horizontal scrollbar appears. Tested on latest Aurora 41.0a2 across platforms (Windows 7 64-bit, Mac OS X 10.10 and Ubuntu 14.04 32-bit).
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: