Closed Bug 1177032 Opened 9 years ago Closed 6 years ago

Implement SVG 1.2 Tiny/SVG 2 solidColor paint server

Categories

(Core :: SVG, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: longsonr, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-needed)

Attachments

(2 files, 1 obsolete file)

No description provided.
Attached patch solidColour.txt (obsolete) (deleted) — Splinter Review
I'll break out some parts like the html parser bit for separate review. Any other bits need other reviewers Cam?
Attachment #8625662 - Flags: review?(cam)
Assignee: nobody → longsonr
Attached image testcase (deleted) —
Attached patch all files this time. (deleted) — Splinter Review
Attachment #8625662 - Attachment is obsolete: true
Attachment #8625662 - Flags: review?(cam)
Attachment #8625666 - Flags: review?(cam)
FYI that the draft SVG 2 specs have changed the capitalization from <solidColor> (as was used in Tiny 1.2) to <solidcolor>. Which removes the HTML parser issue, but also removes any chance at compatibility with Tiny 1.2 content (if any exists out in the wild!).
Cameron, what's your take on this feature? To me it seems like it would be better to have a generic mechanism that works in non-SVG too, but I assume it's still in the SVG 2 draft for a reason?
Flags: needinfo?(cam)
Yeah, I am pretty ambivalent towards this feature. I was more strongly against it in the past but acquiesced. Tav feels that it is a good mechanism for defining reusable colours in an SVG document. My argument was that you can just use CSS Variables for that. CSS Variables is a harder feature for Inkscape to support, though. I don't really want to be the first mover here. Can we wait to see if this gets interest from other vendors first? (Sorry to do that to you Robert.)
Flags: needinfo?(cam)
Attachment #8625666 - Flags: review?(cam)
Comment on attachment 8625666 [details] [diff] [review] all files this time. The patch itself looks reasonable, at a skim, modulo the comments about the changed casing of the element name.
Blocks: svg2
Assignee: longsonr → nobody
removed from SVG 2 spec as nobody wants to implement it.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: