Andrew Comminos [:acomminos] Assignee
	Description • 9 years ago

Steps to reproduce:
- Open two right click context menus whose content dictates they should be sized differently using a GDK scale factor >= 2
- Observe odd spacing or sizing in content

	Andrew Comminos [:acomminos] Assignee
	Comment 1 • 9 years ago

This appears to be the GTK3 equivalent of bug 892994. Whipping up a simple patch that corrects this behaviour using the existing OS X infrastructure.

	Andrew Comminos [:acomminos] Assignee
	Comment 2 • 9 years ago

This patch ensures that the coordinates used for popup widgets are divisible by GDK's scale factor, maintaining consistency between the window and our bounds. Thanks!

	Andrew Comminos [:acomminos] Assignee
	Comment 3 • 9 years ago

Try push (GTK3): https://treeherder.mozilla.org/#/jobs?repo=try&revision=24bede8ad191

	Carsten Book [:Tomcat]
	Comment 4 • 9 years ago

Hey Andrew this try run show a lot of reftest failures are those related to your change ?

	Andrew Comminos [:acomminos] Assignee
	Comment 5 • 9 years ago

Nope, these occur on the main GTK3 branch as well:

https://treeherder.mozilla.org/#/jobs?repo=elm

As the patch only affects GTK3 I didn't see much point in doing a GTK2 try push.

	Pulsebot
	Comment 6 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/ba5ae82b4733

	Ryan VanderMeulen [:RyanVM]
	Comment 7 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/ba5ae82b4733