ISHIKAWA, Chiaki Assignee
	Description • 9 years ago

I have noticed the following errors in the log of xpcshell-tests of C-C TB.

These are relatively new. I don't think I saw them 10 days ago or so.

      1 PROCESS | 13928 | JavaScript strict warning: /NREF-COMM-CENTRAL/objdir-tb3/_tests/xpcshell/toolkit/components/telemetry/tests/unit/test_TelemetrySession.js, line 1541: SyntaxError: octal literals and octal escape sequences are deprecated
      1 PROCESS | 13928 | JavaScript strict warning: /NREF-COMM-CENTRAL/objdir-tb3/_tests/xpcshell/toolkit/components/telemetry/tests/unit/test_TelemetrySession.js, line 1501: SyntaxError: octal literals and octal escape sequences are deprecated
      1 PROCESS | 13928 | JavaScript strict warning: /NREF-COMM-CENTRAL/objdir-tb3/_tests/xpcshell/toolkit/components/telemetry/tests/unit/test_TelemetrySession.js, line 1039: SyntaxError: octal literals and octal escape sequences are deprecated

      ...

      1 "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "SyntaxError: octal literals and octal escape sequences are deprecated" {file: "/NREF-COMM-CENTRAL/objdir-tb3/_tests/xpcshell/toolkit/components/telemetry/tests/unit/test_TelemetrySession.js" line: 1541 column: 42 source: "  let nowDate = new Date(2060, 10, 18, 0, 00, 0);
      1 "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "SyntaxError: octal literals and octal escape sequences are deprecated" {file: "/NREF-COMM-CENTRAL/objdir-tb3/_tests/xpcshell/toolkit/components/telemetry/tests/unit/test_TelemetrySession.js" line: 1501 column: 42 source: "  let nowDate = new Date(2009, 10, 18, 0, 00, 0);
      1 "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "SyntaxError: octal literals and octal escape sequences are deprecated" {file: "/NREF-COMM-CENTRAL/objdir-tb3/_tests/xpcshell/toolkit/components/telemetry/tests/unit/test_TelemetrySession.js" line: 1449 column: 43 source: "  let nowDate = new Date(2009, 10, 18, 00, 00, 0);
      1 "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "SyntaxError: octal literals and octal escape sequences are deprecated" {file: "/NREF-COMM-CENTRAL/objdir-tb3/_tests/xpcshell/toolkit/components/telemetry/tests/unit/test_TelemetrySession.js" line: 1449 column: 39 source: "  let nowDate = new Date(2009, 10, 18, 00, 00, 0);
      1 "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "SyntaxError: octal literals and octal escape sequences are deprecated" {file: "/NREF-COMM-CENTRAL/objdir-tb3/_tests/xpcshell/toolkit/components/telemetry/tests/unit/test_TelemetrySession.js" line: 1039 column: 46 source: "  let dailyOverdue = new Date(2030, 1, 2, 13, 00, 0);

Looking at the code, I think the error/warning are printed by
the use of 00 in the data (minute field?).

Simply using 0 would be suffice and shuts up the JavaScript compiler/interpreter.

TIA

	ISHIKAWA, Chiaki Assignee
	Comment 1 • 9 years ago

Attached patch should fix this issue.

	ISHIKAWA, Chiaki Assignee
	Comment 2 • 9 years ago

Thank you for the review.

I will put in checkin-needed keyword.

	Pulsebot
	Comment 3 • 9 years ago

https://hg.mozilla.org/integration/fx-team/rev/7a6587895fa0

	Ryan VanderMeulen [:RyanVM]
	Comment 4 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/7a6587895fa0

	Georg Fritzsche [:gfritzsche]
	Comment 5 • 9 years ago

Comment on attachment 8626937 [details] [diff] [review]
fix unintended octal literals (00 => 0)

Approval Request Comment
[Feature/regressing bug #]: Unified Telemetry
[User impact if declined]: This is a trivial test-only patch. Uplifting it allows us to avoid rebasing other uplifts.
[Describe test coverage new/current, TreeHerder]: This is an automated test change.
[Risks and why]: No risk, trivial and test-only.
[String/UUID change made/needed]: None.

	Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)
	Comment 6 • 9 years ago

Comment on attachment 8626937 [details] [diff] [review]
fix unintended octal literals (00 => 0)

Approving, test-only change.

	Carsten Book [:Tomcat]
	Comment 7 • 9 years ago

https://hg.mozilla.org/releases/mozilla-aurora/rev/27337d0d6518