I have noticed the following errors in the log of xpcshell-tests of C-C TB. These are relatively new. I don't think I saw them 10 days ago or so. 1 PROCESS | 13928 | JavaScript strict warning: /NREF-COMM-CENTRAL/objdir-tb3/_tests/xpcshell/toolkit/components/telemetry/tests/unit/test_TelemetrySession.js, line 1541: SyntaxError: octal literals and octal escape sequences are deprecated 1 PROCESS | 13928 | JavaScript strict warning: /NREF-COMM-CENTRAL/objdir-tb3/_tests/xpcshell/toolkit/components/telemetry/tests/unit/test_TelemetrySession.js, line 1501: SyntaxError: octal literals and octal escape sequences are deprecated 1 PROCESS | 13928 | JavaScript strict warning: /NREF-COMM-CENTRAL/objdir-tb3/_tests/xpcshell/toolkit/components/telemetry/tests/unit/test_TelemetrySession.js, line 1039: SyntaxError: octal literals and octal escape sequences are deprecated ... 1 "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "SyntaxError: octal literals and octal escape sequences are deprecated" {file: "/NREF-COMM-CENTRAL/objdir-tb3/_tests/xpcshell/toolkit/components/telemetry/tests/unit/test_TelemetrySession.js" line: 1541 column: 42 source: " let nowDate = new Date(2060, 10, 18, 0, 00, 0); 1 "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "SyntaxError: octal literals and octal escape sequences are deprecated" {file: "/NREF-COMM-CENTRAL/objdir-tb3/_tests/xpcshell/toolkit/components/telemetry/tests/unit/test_TelemetrySession.js" line: 1501 column: 42 source: " let nowDate = new Date(2009, 10, 18, 0, 00, 0); 1 "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "SyntaxError: octal literals and octal escape sequences are deprecated" {file: "/NREF-COMM-CENTRAL/objdir-tb3/_tests/xpcshell/toolkit/components/telemetry/tests/unit/test_TelemetrySession.js" line: 1449 column: 43 source: " let nowDate = new Date(2009, 10, 18, 00, 00, 0); 1 "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "SyntaxError: octal literals and octal escape sequences are deprecated" {file: "/NREF-COMM-CENTRAL/objdir-tb3/_tests/xpcshell/toolkit/components/telemetry/tests/unit/test_TelemetrySession.js" line: 1449 column: 39 source: " let nowDate = new Date(2009, 10, 18, 00, 00, 0); 1 "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "SyntaxError: octal literals and octal escape sequences are deprecated" {file: "/NREF-COMM-CENTRAL/objdir-tb3/_tests/xpcshell/toolkit/components/telemetry/tests/unit/test_TelemetrySession.js" line: 1039 column: 46 source: " let dailyOverdue = new Date(2030, 1, 2, 13, 00, 0); Looking at the code, I think the error/warning are printed by the use of 00 in the data (minute field?). Simply using 0 would be suffice and shuts up the JavaScript compiler/interpreter. TIA

Attached patch should fix this issue.

Thank you for the review. I will put in checkin-needed keyword.

Comment on attachment 8626937 [details] [diff] [review] fix unintended octal literals (00 => 0) Approval Request Comment [Feature/regressing bug #]: Unified Telemetry [User impact if declined]: This is a trivial test-only patch. Uplifting it allows us to avoid rebasing other uplifts. [Describe test coverage new/current, TreeHerder]: This is an automated test change. [Risks and why]: No risk, trivial and test-only. [String/UUID change made/needed]: None.

Comment on attachment 8626937 [details] [diff] [review] fix unintended octal literals (00 => 0) Approving, test-only change.