Flaviu Cos Reporter
	Description • 9 years ago

Environment: 
Device: Motorola Razr (Android 4.4.4);
Build: Nightly 42.0a1 (2015-06-29);

Steps to reproduce:
1. Go to about:telemetry;
2. Tap on 'Change' button.

Expected result:
The telemetry settings can be disabled or enabled from about:telemetry. 

Actual result:
Nothing is happening when tapping on 'change' button. 

Notes:
The following error is thrown in logcat:

JavaScript Error: "TypeError: mainWindow is null" {file: "chrome://global/content/aboutTelemetry.js" line: 24}

	:Margaret Leibovic
	Comment 1 • 9 years ago

Georg, did you test this on mobile?

	Georg Fritzsche [:gfritzsche] Assignee
	Comment 2 • 9 years ago

Ah, no, that slipped through sadly.
Any idea what the equivalent on mobile is to open the datachoices preferences?

	Kevin Brosnan [Ex-Mozilla]
	Comment 3 • 9 years ago

[Tracking Requested - why for this release]: regression I do not believe this blocks turning on Aurora updates.

	:Margaret Leibovic
	Comment 4 • 9 years ago

(In reply to Georg Fritzsche [:gfritzsche] from comment #2)
> Ah, no, that slipped through sadly.
> Any idea what the equivalent on mobile is to open the datachoices
> preferences?

The preferences are native, so you may need to do some JNI hacks for that... I did something similar for the privacy coach add-on:
https://github.com/leibovic/privacy-coach/blob/master/content/welcome.js#L139

We include a version of JNI.jsm in the tree, so you should be able to just import that and use it.

I agree with kbrosnan that I don't think this is a show-stopper.

	Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)
	Comment 5 • 9 years ago

Adding a tracking flag for Firefox41 and Firefox42 as this a regression and was found during QE Aurora Sign-off testing.

	Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)
	Comment 6 • 9 years ago

Georg,

	Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)
	Comment 7 • 9 years ago

Georg, is this something that will be fixed for FF41? Is there a patch in progress? Or do you think it is better to track this for FF42 instead?

	:Margaret Leibovic
	Comment 8 • 9 years ago

rnewman also directed me to the about:healthreport code, which uses a supported JS->Java message to show the settings page:

http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/aboutHealthReport.js#120

That's probably better than trying to use JNI :)

	Georg Fritzsche [:gfritzsche] Assignee
	Comment 9 • 9 years ago

This won't make 41, lets track for 42.
(If no-one is assigned to the bug then it isn't actively being worked on.)

Thanks for the pointer Margaret, will try to get here when other work allows :)

	:Margaret Leibovic
	Comment 11 • 9 years ago

Comment on attachment 8661693 [details] [diff] [review]
Fix about:telemetry "change" buttons on Fennec

Review of attachment 8661693 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, thanks for the patch!

::: toolkit/content/aboutTelemetry.js
@@ +15,5 @@
>  Cu.import("resource://gre/modules/TelemetryArchive.jsm");
>  Cu.import("resource://gre/modules/TelemetryUtils.jsm");
>  Cu.import("resource://gre/modules/TelemetryLog.jsm");
>  Cu.import("resource://gre/modules/Preferences.jsm");
> +Cu.import("resource://gre/modules/AppConstants.jsm");

This could be a lazy import, since it's not used until the button is clicked.

	Pulsebot
	Comment 13 • 9 years ago

https://hg.mozilla.org/integration/fx-team/rev/810363f6cbc3

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 14 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/810363f6cbc3

	Flaviu Cos Reporter
	Comment 15 • 9 years ago

Tapping on 'Change' button will open Setting->Mozilla. Is this expected?

Tested on latest Nightly (2015-09-18) on Motorola Razr (Android 4.4.4).

	Georg Fritzsche [:gfritzsche] Assignee
	Comment 16 • 9 years ago

Yes, that is expected.
That page contains the data choices, i.e. what you use to change those settings.

	Flaviu Cos Reporter
	Comment 17 • 9 years ago

Verified as fixed in build 43.0a1 2015-09-18;
Device: Motorola Razr (Android 4.4.4).

	Sylvestre Ledru [:Sylvestre]
	Comment 18 • 9 years ago

Georg, do you have plans to uplift this patch to 42? Thanks

	Georg Fritzsche [:gfritzsche] Assignee
	Comment 19 • 9 years ago

I don't think this fix is important enough to uplift to Beta, i'd rather leave it riding 43.

	Sylvestre Ledru [:Sylvestre]
	Comment 20 • 9 years ago

OK, thanks. Untracking it then.