:Gijs (he/him) Reporter
	Description • 9 years ago

In the dark theme, when tabs are overflowing, the new tab and tablist dropdown icon are outside the "dark" styled portion of the #TabsToolbar.

However, it seems like the entire toolbar gets the [brighttext] attribute and therefore we use the inverted graphics. Because they have outer borders, they are not invisible, but I believe it would still be better if we used the same icons we would have used without the dark devedition theme being active.

	Brian Grinstead [:bgrins]
	Comment 1 • 9 years ago

I wonder what the best way to tackle this is.  We could just override the particular *-inverted.png with the corresponding *.png icons in devedition.css.  Or we could add an additional attribute to the TabsToolbar (or :root) indicating that we have the DE theme applied and then modify the selector to not apply the inverted icon in the first place when that's true.  Or we could add some metadata to the lw theme system that allows a similar attribute to be applied more generically.

I think in any individual case going with the first approach (just override the most narrow thing possible) is easier, but I do wonder as stuff like this adds up if it'd be easier to just handle some of the DE stuff directly within the browser.css files.  We avoided that originally so the DE theme didn't get any special treatment.  But it can bite as images get converted to 2x, for example (as evidenced in Bug 1165360 which was triggered by Bug 1147702).  And I could see the same problem happening here.