Closed Bug 1179295 Opened 9 years ago Closed 9 years ago

Forward arrow is stretched vertically in Windows 10 theme

Categories

(Firefox :: Theme, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 42
Tracking Status
firefox40 + verified
firefox41 --- verified
firefox42 --- verified

People

(Reporter: phlsa, Assigned: dao)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(2 files, 1 obsolete file)

Attached image stretched arrow (deleted) —
Since the increase in height of the location bar, the forward navigation arrow is stretched vertically. The back arrow is fine though.
Indeed a regression of bug 1173736
Blocks: 1173736
Keywords: regression
Assignee: nobody → dao
Attached patch patch (obsolete) (deleted) — Splinter Review
Attachment #8629485 - Flags: review?(jaws)
Attachment #8629485 - Flags: review?(jaws) → review+
Attached patch patch (deleted) — Splinter Review
I had to update another rule for non-default buttons
Attachment #8629485 - Attachment is obsolete: true
Flags: qe-verify+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
I found arrow is stretched on Firefox nightly 42.0a1 (2015-07-01) with Windows 10 x64 . User Agent : Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:42.0) Gecko/20100101 Firefox/42.0 Affected Build : 20150701030207 Fixed on : 20150701030207 Suggesting STATUS -> VERIFIED FIXED [Bugday-20150708]
Thanks!
Status: RESOLVED → VERIFIED
(In reply to Rezaul Huque Nayeem from comment #6) > I found arrow is stretched on Firefox nightly 42.0a1 (2015-07-01) with > Windows 10 x64 . > > User Agent : Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:42.0) > Gecko/20100101 Firefox/42.0 > > Affected Build : 20150701030207 > Fixed on : 20150701030207 Your "affected build" and "fixed on" show the same build times. Shouldn't these be different?
Flags: needinfo?(rhnayeem01)
It's my mistake. When I was copying my second build id , my keyboard shortcut (ctrl+c) didn't work . Re-correcting this : Affected Build : 20150701030207 Fixed on : 20150707030206
Flags: needinfo?(rhnayeem01)
Comment on attachment 8630007 [details] [diff] [review] patch Approval Request Comment [Feature/regressing bug #]: bug 1173736 / windows 10 [User impact if declined]: see comment 0 [Describe test coverage new/current, TreeHerder]: n/a [Risks and why]: straightforward CSS patch, low risk, also baked very long because I missed getting this uplifted earlier [String/UUID change made/needed]: none
Attachment #8630007 - Flags: approval-mozilla-beta?
Attachment #8630007 - Flags: approval-mozilla-aurora?
Depends on: 1187727
Bug 1184728 (which depends on this patch) already got uplifted, which caused Bug 1187727 on Aurora. Ritu, we will need to either get this patch approved and uplifted for Aurora today or back out the patch from Bug 1184728 on Aurora in the meantime. Please let me know what is best.
Blocks: 1184728
Flags: needinfo?(rkothari)
Comment on attachment 8630007 [details] [diff] [review] patch Windows 10 fix for forward nav button size regression. Beta+ Aurora+
Attachment #8630007 - Flags: approval-mozilla-beta?
Attachment #8630007 - Flags: approval-mozilla-beta+
Attachment #8630007 - Flags: approval-mozilla-aurora?
Attachment #8630007 - Flags: approval-mozilla-aurora+
(In reply to Brian Grinstead [:bgrins] from comment #11) > Bug 1184728 (which depends on this patch) already got uplifted, which caused > Bug 1187727 on Aurora. Ritu, we will need to either get this patch approved > and uplifted for Aurora today or back out the patch from Bug 1184728 on > Aurora in the meantime. Please let me know what is best. I just approved this fix for Aurora. We'll get this landed today and tonight's build should have the fix.
Flags: needinfo?(rkothari)
Reproduced the bug with Nightly 42.0a1 (2015-07-01). This is verified fixed on Nightly 42.0a1 (2015-07-27) and Beta 40.0b8 (20150727174134), using Windows 10 Pro x64 (Build 10240), see: http://i.imgur.com/hYGuMe3.png.
Verified fixed on Aurora 41.0a2 (2015-07-29) as well, using Windows Pro x64 (Build 10240).
Depends on: 1204441
Depends on: 1206100
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: