Closed
Bug 1179295
Opened 9 years ago
Closed 9 years ago
Forward arrow is stretched vertically in Windows 10 theme
Categories
(Firefox :: Theme, defect)
Firefox
Theme
Tracking
()
VERIFIED
FIXED
Firefox 42
People
(Reporter: phlsa, Assigned: dao)
References
(Blocks 1 open bug)
Details
(Keywords: regression)
Attachments
(2 files, 1 obsolete file)
(deleted),
image/png
|
Details | |
(deleted),
patch
|
lmandel
:
approval-mozilla-aurora+
lmandel
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Since the increase in height of the location bar, the forward navigation arrow is stretched vertically.
The back arrow is fine though.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → dao
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8629485 -
Flags: review?(jaws)
Updated•9 years ago
|
Attachment #8629485 -
Flags: review?(jaws) → review+
Assignee | ||
Comment 3•9 years ago
|
||
I had to update another rule for non-default buttons
Attachment #8629485 -
Attachment is obsolete: true
Assignee | ||
Updated•9 years ago
|
Flags: qe-verify+
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Comment 6•9 years ago
|
||
I found arrow is stretched on Firefox nightly 42.0a1 (2015-07-01) with Windows 10 x64 .
User Agent : Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:42.0) Gecko/20100101 Firefox/42.0
Affected Build : 20150701030207
Fixed on : 20150701030207
Suggesting STATUS -> VERIFIED FIXED
[Bugday-20150708]
Comment 8•9 years ago
|
||
(In reply to Rezaul Huque Nayeem from comment #6)
> I found arrow is stretched on Firefox nightly 42.0a1 (2015-07-01) with
> Windows 10 x64 .
>
> User Agent : Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:42.0)
> Gecko/20100101 Firefox/42.0
>
> Affected Build : 20150701030207
> Fixed on : 20150701030207
Your "affected build" and "fixed on" show the same build times. Shouldn't these be different?
Flags: needinfo?(rhnayeem01)
Comment 9•9 years ago
|
||
It's my mistake. When I was copying my second build id , my keyboard shortcut (ctrl+c) didn't work .
Re-correcting this :
Affected Build : 20150701030207
Fixed on : 20150707030206
Flags: needinfo?(rhnayeem01)
Assignee | ||
Comment 10•9 years ago
|
||
Comment on attachment 8630007 [details] [diff] [review]
patch
Approval Request Comment
[Feature/regressing bug #]: bug 1173736 / windows 10
[User impact if declined]: see comment 0
[Describe test coverage new/current, TreeHerder]: n/a
[Risks and why]: straightforward CSS patch, low risk, also baked very long because I missed getting this uplifted earlier
[String/UUID change made/needed]: none
Attachment #8630007 -
Flags: approval-mozilla-beta?
Attachment #8630007 -
Flags: approval-mozilla-aurora?
Comment 11•9 years ago
|
||
Bug 1184728 (which depends on this patch) already got uplifted, which caused Bug 1187727 on Aurora. Ritu, we will need to either get this patch approved and uplifted for Aurora today or back out the patch from Bug 1184728 on Aurora in the meantime. Please let me know what is best.
Blocks: 1184728
Flags: needinfo?(rkothari)
Comment 12•9 years ago
|
||
Comment on attachment 8630007 [details] [diff] [review]
patch
Windows 10 fix for forward nav button size regression. Beta+ Aurora+
Attachment #8630007 -
Flags: approval-mozilla-beta?
Attachment #8630007 -
Flags: approval-mozilla-beta+
Attachment #8630007 -
Flags: approval-mozilla-aurora?
Attachment #8630007 -
Flags: approval-mozilla-aurora+
Updated•9 years ago
|
Comment 13•9 years ago
|
||
(In reply to Brian Grinstead [:bgrins] from comment #11)
> Bug 1184728 (which depends on this patch) already got uplifted, which caused
> Bug 1187727 on Aurora. Ritu, we will need to either get this patch approved
> and uplifted for Aurora today or back out the patch from Bug 1184728 on
> Aurora in the meantime. Please let me know what is best.
I just approved this fix for Aurora. We'll get this landed today and tonight's build should have the fix.
Updated•9 years ago
|
Flags: needinfo?(rkothari)
Assignee | ||
Comment 14•9 years ago
|
||
Assignee | ||
Comment 15•9 years ago
|
||
Comment 16•9 years ago
|
||
Reproduced the bug with Nightly 42.0a1 (2015-07-01).
This is verified fixed on Nightly 42.0a1 (2015-07-27) and Beta 40.0b8 (20150727174134), using Windows 10 Pro x64 (Build 10240), see: http://i.imgur.com/hYGuMe3.png.
Comment 17•9 years ago
|
||
Verified fixed on Aurora 41.0a2 (2015-07-29) as well, using Windows Pro x64 (Build 10240).
You need to log in
before you can comment on or make changes to this bug.
Description
•