Closed
Bug 1179689
Opened 9 years ago
Closed 9 years ago
Re-enable test_play_ogv_video, test_play_webm_video, and test_play_ogg_video tests after Bug 1113086 is landed
Categories
(Firefox OS Graveyard :: Gaia::Video, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: evanxd, Assigned: evanxd)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-github-pull-request
|
Details |
Re-enable test_play_ogv_video, test_play_webm_video, and test_play_ogg_video tests after Bug 1113086 is landed.
|
Assignee | |
Updated•9 years ago
|
|
||
Comment 2•9 years ago
|
||
|
|
Assignee | |
Comment 3•9 years ago
|
||
|
|
Assignee | |
Comment 4•9 years ago
|
||
|
||
Comment 5•9 years ago
|
||
Evan, I think your pull request can be checked in now, right? (at least, when the tree gets reopened again).
Flags: needinfo?(evan)
|
|
Assignee | |
Comment 6•9 years ago
|
||
Yes, I think we can re-enable the test now. But is treeherder running Gip tasks now?
CI[1] for re-enabling the test.
[1]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=4872460bb5c3eae9542aebf519c9a4fbdedb4da4
Flags: needinfo?(evan)
|
|
Assignee | |
Comment 7•9 years ago
|
||
I didn't see Gip tasks on treeherder.
|
|
||
Comment 8•9 years ago
|
||
No, Gip has been hidden on treeherder and will soon be disabled completely there. We're only running Gip on Jenkins now.
|
|
||
Comment 9•9 years ago
|
||
I just tested test_play_ogg_video.py locally and it is passing for me. I'm sure the other ones will pass as well.
Could you please merge the pull request? Thanks!
Flags: needinfo?(evan)
|
|
Assignee | |
Comment 11•9 years ago
|
||
But we need to wait for the GijTV[1] is passed. Then I'll land the code.
[1]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=4872460bb5c3eae9542aebf519c9a4fbdedb4da4
|
|
Assignee | |
Comment 12•9 years ago
|
||
treeherder: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=59e70a72897579137e44d98263b15d36359fea59
If it's good, let's land the code.
|
|
||
Comment 13•9 years ago
|
||
(In reply to Evan Tseng [:evanxd][:愛聞插低] from comment #11)
> But we need to wait for the GijTV[1] is passed. Then I'll land the code.
>
> [1]:
> https://treeherder.mozilla.org/#/
> jobs?repo=gaia&revision=4872460bb5c3eae9542aebf519c9a4fbdedb4da4
This pull request has nothing to do with Gij tests. So no need to check for those.
Ok, merged the pull request, thanks!
https://github.com/mozilla-b2g/gaia/commit/e4ea78037faeca3bba253f9af56dd341c52e1649
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•