Closed
Bug 1180205
Opened 9 years ago
Closed 9 years ago
Disable Unified Complete in Firefox 41
Categories
(Toolkit :: Places, defect, P1)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla41
Tracking | Status | |
---|---|---|
firefox40 | --- | unaffected |
firefox41 | --- | fixed |
firefox42 | --- | unaffected |
People
(Reporter: mak, Assigned: mak)
References
Details
(Whiteboard: [unifiedcomplete][fxsearch])
Attachments
(1 file)
(deleted),
patch
|
adw
:
review+
kglazko
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Unified complete is currently enabled in Aurora.
Considered the first feature taking good benefits from it is search suggestions, and those are only enabled in Firefox 42 (bug 958204).
Also considering the fact we still have regression (bug 1176437, bug 1172937, bug 1047613) that we are working on right now.
I feel like the benefit in keeping the feature enabled in Aurora is not enough vs the price to keep it up to date with nightly by uplifiting patches and tracking all the changes.
I think we should release it along with search suggestions, or in the version where most regressions will be fixed. Releasing a non-top quality awesomebar experience should be a no-go.
However, I'd be fine doing this disabling closer to the Beta merge, so we get more Aurora testing.
Flags: needinfo?(dtownsend)
Flags: firefox-backlog?
Assignee | ||
Updated•9 years ago
|
status-firefox40:
--- → unaffected
status-firefox41:
--- → affected
Assignee | ||
Updated•9 years ago
|
Blocks: UnifiedComplete
Comment 1•9 years ago
|
||
Yeah this makes sense
Flags: needinfo?(dtownsend)
Flags: firefox-backlog?
Flags: firefox-backlog+
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Updated•9 years ago
|
Rank: 4
Assignee | ||
Comment 2•9 years ago
|
||
Assignee | ||
Comment 3•9 years ago
|
||
Comment on attachment 8631477 [details] [diff] [review]
patch v1
ok, the failures don't look related to this.
Attachment #8631477 -
Flags: review?(adw)
Updated•9 years ago
|
Attachment #8631477 -
Flags: review?(adw) → review+
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8631477 [details] [diff] [review]
patch v1
Approval Request Comment
[Feature/regressing bug #]: unified complete
[User impact if declined]: the feature is not on-par with quality to ride the trains to release
[Describe test coverage new/current, TreeHerder]: unit tests
[Risks and why]: no risk, just reverting to the old component
[String/UUID change made/needed]: none
Attachment #8631477 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 5•9 years ago
|
||
This should only land in Aurora.
Comment 6•9 years ago
|
||
Comment on attachment 8631477 [details] [diff] [review]
patch v1
Approving uplift to Aurora because low risk, only backing out.
Attachment #8631477 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 7•9 years ago
|
||
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in
before you can comment on or make changes to this bug.
Description
•