Andrew Comminos [:acomminos] Assignee
	Description • 9 years ago

The way the reftest for bug 1174332 calculates the bounds for the box shadow causes some issues on GTK3 themes that draw partially transparent focused checkboxes, such as the version of Ambiance on the test infrastructure.

The flood bounds for the checkbox in the reference are calculated as follows;

> <feMorphology operator="dilate" radius="5" in="SourceAlpha" result="mask"/>

However, this produces unexpected results with Ambiance's focused checkbox. The attachment makes it clear why that might be so.

	Andrew Comminos [:acomminos] Assignee
	Comment 1 • 9 years ago

The issue here is that the box-shadow test draws the checkbox directly on the blue background, causing accumulated error with multiple compositions by the theme engine (it composites each part of the checkbox onto the background, such as the background, outline, focus ring, etc). The SVG reference instead draws the widget on a temporary clear surface, and composites that onto the background. This issue is present throughout many reftests that we fuzz when gtkWidget is true.

This patch adds extra fuzziness for the tryserver's GTK3 theme.

	Pulsebot
	Comment 2 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/cb1d12d4ccfd

	Carsten Book [:Tomcat]
	Comment 3 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/cb1d12d4ccfd