Closed Bug 1180253 Opened 9 years ago Closed 8 years ago

Syntax Highlighter does not like template strings

Categories

(DevTools :: Debugger, defect)

defect
Not set
normal

Tracking

(firefox42 affected)

RESOLVED FIXED
Tracking Status
firefox42 --- affected

People

(Reporter: julienw, Unassigned)

References

Details

Attachments

(1 file)

I have this code in my app: () => console.log(`Finished executeNavigationStep(${stepName})`) The syntax highlighter matches the ")" inside the string with the opening parens. See attachment
Strange. We use CodeMirror 4.2 and support for template strings was apparently added in 4.1: http://codemirror.net/doc/releases.html There is bug 1132557 for upgrading to a newer version, but if the bug is still there on the web-hosted version, this should be reported to the CodeMirror issue tracker.
Actually, Template strings work, but the parens inside the template string is badly matched.
It seems to work with latest version of CodeMirror (I tried directly on the website's examples). Let's see what happens after an upgrade then :)
Depends on: 1132557
I think this works now; I tried a simple example with both debuggers and it seemed ok. There have been several CodeMirror upgrades in-tree since comment #3. So, I'm marking this as fixed.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: