Closed
Bug 1180288
Opened 9 years ago
Closed 9 years ago
Use native filepickers for Graphene
Categories
(Firefox OS Graveyard :: Runtime, defect)
Tracking
(firefox45 fixed)
RESOLVED
FIXED
FxOS-S11 (13Nov)
| Tracking | Status | |
|---|---|---|
| firefox45 | --- | fixed |
People
(Reporter: bbondy, Assigned: bbondy)
Details
(Whiteboard: graphene-larch)
Attachments
(1 file)
|
(deleted),
patch
|
fabrice
:
review+
khuey
:
review+
|
Details | Diff | Splinter Review |
Currently `<input type="file">` does not work on graphene due to the b2g file picker implementation using a web activities and device storage API to get files. We should use the native file pickers in widget instead when MOZ_GRAPHENE is defined.
|
Assignee | |
Comment 1•9 years ago
|
||
Uploaded with graphene on OSX :)
Assignee: nobody → netzen
Attachment #8629489 -
Flags: review?(fabrice)
|
|
Assignee | |
Updated•9 years ago
|
Whiteboard: graphene-larch
|
||
Updated•9 years ago
|
Attachment #8629489 -
Flags: review?(fabrice) → review+
|
|
||
Comment 2•9 years ago
|
||
|
|
Assignee | |
Comment 3•9 years ago
|
||
Relanded with proper patch headers:
http://hg.mozilla.org/projects/larch/rev/80f39a3a53a9
http://hg.mozilla.org/projects/larch/rev/7623f490f057
|
||
Comment 4•9 years ago
|
||
Larch was merged to mozilla-central in bug 1204965, but this was not included due to not having a review from a DOM peer. Please have a DOM peer review if this is still needed as it touches code in the dom directory.
Flags: needinfo?(netzen)
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8629489 -
Flags: review?(khuey)
|
|
Assignee | |
Updated•9 years ago
|
Flags: needinfo?(netzen)
Comment on attachment 8629489 [details] [diff] [review]
filepicker.diff
Review of attachment 8629489 [details] [diff] [review]:
-----------------------------------------------------------------
I admit to having no idea what this is ... but ok ...
Attachment #8629489 -
Flags: review?(khuey) → review+
|
|
Assignee | |
Comment 6•9 years ago
|
||
Thanks for the second pass, Graphene is just a runtime based on b2g for browser.html and Horizon (VR)
|
|
Assignee | |
Comment 8•9 years ago
|
||
Since it's been a while I re-verified that on Graphene filepickers only work with this patch.
|
||
Comment 9•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S11 (13Nov)
|
|
||
Comment 10•9 years ago
|
||
| bugherder | ||
You need to log in
before you can comment on or make changes to this bug.
Description
•