Closed Bug 1180330 Opened 9 years ago Closed 9 years ago

http auth prompt shown when opening browser if prompt canceled/dismissed earlier

Categories

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect, P1)

ARM
Gonk (Firefox OS)
defect

Tracking

(firefox46 fixed)

RESOLVED FIXED
2.6 S5 - 1/15
Tracking Status
firefox46 --- fixed

People

(Reporter: aryx, Assigned: ferjm)

References

Details

Attachments

(2 files, 1 obsolete file)

B2G 2.2 20150703002506 on Flame (v18D base image) A http auth prompt is shown when opening browser after the prompt had been dismissed earlier. Steps to reproduce: 1. Open Browser. 2. Enter IP address of router (uses HTTP). 3. Dismiss http auth prompt. 4. Long press home button and closes alls browser windows. 5. Tap on Browser button on home screen. Actual result: HTTP auth prompt gets loaded. Expectd result: Homescreen with tiles loaded and remains open. I can't reproduce the issue with https://mxr.mozilla.org/addons/
Blocks: fxos-sync
Component: Gaia::Bookmark → Gaia::System::Browser Chrome
Priority: -- → P1
Target Milestone: --- → 2.6 S2 - 12/4
I can reproduce it when repeating steps 4 and 5 twice. The first time I get the tiles, the second time I get the prompt.
Assignee: nobody → ferjmoreno
You can also just wait 10 seconds when you see the tiles, the prompt will come eventually.
Target Milestone: 2.6 S2 - 12/4 → 2.6 S3 - 12/18
Target Milestone: 2.6 S3 - 12/18 → 2.6 S4 - 1/1
Status: NEW → ASSIGNED
Target Milestone: 2.6 S4 - 1/1 → 2.6 S5 - 1/15
Attached patch v1 (obsolete) (deleted) — Splinter Review
The problem here is that the system app always tries to fetch the favicon to show it on the browser history list and on the rocketbar. In these cases, we shouldn't show the auth dialog and simply let the fetch request fail with a 401. To do that we need to expose the full path of the fetch request along with the 'mozbrowserusernameandpasswordrequired' event.
Comment on attachment 8705252 [details] [diff] [review] v1 Kan-Ru, could you take a look at this patch, please? It exposes the URI path along with the 'mozbrowserusernameandpasswordrequired' event, so the system app can decide if the auth prompt is required or not.
Attachment #8705252 - Flags: review?(kchen)
Attachment #8705252 - Flags: review?(kchen) → review?(fabrice)
Comment on attachment 8705252 [details] [diff] [review] v1 Actually, I can write a test for this.
Attachment #8705252 - Flags: review?(fabrice)
Attached patch v1 (deleted) — Splinter Review
Attachment #8705252 - Attachment is obsolete: true
Attachment #8705289 - Flags: review?(fabrice)
Attachment #8705289 - Flags: review?(fabrice) → review+
Attachment #8705255 - Flags: review?(etienne)
Comment on attachment 8705255 [details] [gaia] ferjm:bug1180330.http.auth.prompt > mozilla-b2g:master cool :)
Attachment #8705255 - Flags: review?(etienne) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/6aee0abef4656489d6da543c1bc50384a776420e Bug 1180330 - http auth prompt shown when opening browser if prompt canceled/dismissed earlier. r=fabrice
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: