Closed Bug 1180374 Opened 9 years ago Closed 4 years ago

multiple master password prompts since TB 38 (still in 60)

Categories

(Thunderbird :: Security, defect)

Product:
Thunderbird
Component:
Security
Version:
38 Branch
Platform:
x86_64
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: wolfiR, Unassigned)

References

Details

(Keywords: regression, regressionwindow-wanted, Whiteboard: [regression:TB38?]) 

I found some very old bugreports about a similar issue but nothing new since TB 38.0.1.
Since my addons and my accounts did not change between TB31 and 38 I consider this a direct regression.

With TB31 I got one master password prompt at startup.
With TB38.0.1 I get immediately 4 of them overlapping each other so I need to enter my master password four times in a row.

I have 3 IMAP accounts, 2 NNTP and 1 XMPP on that system.
we have several reports of this in support forum and such.
Do you have calendar installed?
Component: General → Security
Flags: needinfo?(mozilla)
I see the same behaviour on two systems. But the one cited above with the numbers does NOT have Lightning/Calendar activated.
Flags: needinfo?(mozilla)
We're seeing quite a few posts in SUMO about password prompts, and also comments in crash reports which are hangs.

But not much new stuff being reported in bugzilla - most in this query don't fit the mold of this bug
https://bugzilla.mozilla.org/buglist.cgi?o5=substring&bug_id=973759%20967801%20%201158217%201152528%201122762%201158217%201152528%201122762%20497543%20433238%20360064%20348997%20348941%201167968%201119554%201121119%20918724%201161686%20918724%201167918%201188034%201164364%20524403%201124895%201167968%201119554%201121119%201170088%20917325%201119063%201168126%201101026%20%20%20998893%201120129%201121040%201134846%201145754%201152422%201155390%201118511%201120129%201121040%201121292%201123927%201124039%201147651%201152422%201155390%201156400%201156601%20%201171502%201172672%201172758%201173688%20%20%2038933%20170603%20177175%20224406%20%20%201132211%201165505%20267203%20105843%20112564%201167523%201176025%201150274%20%20%2057351%20896620%20158030%201058438%20209423%20464810%20517953%201182218%20286857%20%20%20499223%201191084%20983326%201174333%201183908%201188622%201192066%201118400%201186123%201190938%201181814%201121291%20259996%20691148%20%20%201174815%201175273%201129582%201187695%201067069%201153250%201135657%201188733%201178055%201095029%201144856%201148196%201169702%20680726%201148325%201178855%201183442%201175941%201188456%201183071%20%20%201185000%20999544%201182296%20865789%201138678%201185443%201185112%201185113%20687745%201148771%20%201185113%201163339%20999544&list_id=12462781&bug_severity=blocker&bug_severity=critical&bug_severity=major&bug_severity=normal&j2=OR&o1=nowordssubstr&o9=anywordssubstr&v10=thunderbird&v5=dataloss&v9=thunderbird%20mail&chfieldfrom=95d&o4=anywordssubstr&v1=test%20intermi%20sync%20telemetry%20door%20show%20crash&longdesc_type=allwordssubstr&v4=secur%20places&f10=longdesc&bug_id_type=nowords&f1=short_desc&o3=anywordssubstr&o7=nowordssubstr&j8=OR&f8=OP&v3=password%20certif%20lost%20pwd&o11=substring&resolution=---&resolution=FIXED&resolution=INVALID&resolution=WONTFIX&classification=Client%20Software&classification=Components&v7=test%20layout%20mach&f9=product&f4=component&chfieldto=Now&query_format=advanced&o10=substring&f3=short_desc&f2=OP&f11=short_desc&longdesc=password&f5=keywords&f6=CP&product=Core&product=MailNews%20Core&product=NSS&product=Thunderbird&product=Toolkit&f7=component
See Also: → https://bugzilla.mozilla.org/show_bug.cgi?id=1102688
Hi,

I have the same problem here: some calendars and some email accounts configured and my passwords "protected" with master password (because LaZagne showed how the default set up is insecure!). And multiple pop ups to ask for master password at Thunderbird's opening.

And I have even more dramatic problems:

1. I use AwesomeWM and open automatically ThB at startup and on a specific "desktop" ("tag"). If I do not fill/cancel at least 1 of the popups quickly, and if move around  between the "desktops", and then come back to the "desktop" where ThB is opened, I cannot validate/cancel the pop ups (even if I can fill the "password" field!). The only available option I found is to kill ThB with "pkill thunderbird"

2. I encountered the situation above (and removed the .lock & .parentlock files) at the same time (Ubuntu) as my system was updating ThB's package. Now, everytime I try to open ThB, I see the pop ups, but when I fill/cancel a few of them, the main ("Mail") ThB window as well as the remaining popups just disappear... So I have no way to do anything in any GUI. 
However, I've tried starting ThB from command-line, and when this occurs, the process does not end, so I know ThB is still running, but with no GUI to control it :{

I would welcome any advise to get back at least a minimal control over ThB... 

This bug might be duplicate of:
https://bugzilla.mozilla.org/show_bug.cgi?id=857080
https://bugzilla.mozilla.org/show_bug.cgi?id=682474
https://bugzilla.mozilla.org/show_bug.cgi?id=643265
https://bugzilla.mozilla.org/show_bug.cgi?id=275547
https://bugzilla.mozilla.org/show_bug.cgi?id=584014
For the record, if it can help someone: I managed to get access again to ThB:
1. $ mv ~/.thunderbird{,OLD} # rename config dir
2. $ thunderbird # just open it, configure nothing & quit
3. $ mv ~/.thunderbird{OLD,} # rename config dir back

With this I can now run ThB. I still have the millions of popups, but I can see the "main" GUI, go to "Preferences->Security", uncheck the 'Master Password", enter my password to definitively unlock the keychain.

PS: SOMEBODY NEEDS TO MARK THIS BUG AS A SECURITY VULN!
Indeed, enabling again the master password results in ThB faulting back to it erroneous behavious: closing down randlomly when password-asking pop-ups are validated/cancelled. This means one cannot use a "Master Password" in this release at all if some calendar are in use. This means all the passwords for all email/news/IM/calendar are exposed!
PS: I'm using 38.2.0
Confirmed for 38.2.0 on Gentoo Linux amd64.

Three popups in a row, of which only one has to be filled in. TB unlocks the password store even if the other two are cancelled.
Hello
I confirm this problem with TB 38.3.0 (regression) + Windows 7
Same problem with TB41
No problem with TB31.2.0
(sorry for the translation :-( )
/------------------------------\
Bonjour
Je confirme ce problème avec TB38.3.0 ( régression !)  + Windows 7 
Meme problème avec TB41 
Pas de problème avec TB31.2.0 
(désolé pour la traduction :-( )
Using gmail OAUTH? Dupe of bug 1176399?
Bonjour / Hello 
@ Magnus Melin - Using Gmail OAuth?
Yes
By disabling Gmail OAuth (TB38) is ok
The solution with the Startup Master extension also works well
https://addons.mozilla.org/fr/thunderbird/addon/startupmaster/
/------------------------------------------\
Bonjour
@ Magnus Melin    - Using gmail OAUTH? 
Oui 
En désactivant OAUTH  de Gmail (TB38) c'est ok 
La solution avec l'extension Startup Master fonctionne aussi très bien 
https://addons.mozilla.org/fr/thunderbird/addon/startupmaster/
GMail oauth is not the trigger for me.
I do not use a Google mail account in my Thunderbird installations. In one I probably have Google calendar in Lightning but the other does not even have Lightning enabled. Therefore oauth is not the only issue.
Same here,
It looks to me that Lightning could be triggering this too, the Lightbird add-on and possibly the EWS Exchange Calendar add-on (Sorry, I have not tested the case here).
Bonjour/Hello 

Results of my tests:
With Lightning = ok (no multiple window starting TB)
With Lightning + Provider for Google Calendar +1 Google calendar = Multiple Windows startup TB
The extension master startup does not change the problem = Multiple Windows startup TB
with Imap account google + 1 OAuth2 = Multiple Windows startup TB
With the extension Startup Master = ok (no multiple window starting TB)

With Lightning + Delete Google Calendar = ok (no multiple window starting TB)
With the extension Google Calendar Tab = ok (no multiple window starting TB)
This extension displays Google Calendar in a tab

(sorry for the translation :-( ) 
/-------------------------------------------------\
Résultat de mes essais:
Avec Lightning = ok (pas de fenêtre multiples au démarrage de TB)
Avec Lightning + Provider for google calendar + 1 agenda Google  =  Fenêtres multiples au démarrage de TB
L'extension startup master ne change rien au problème = Fenêtres multiples au démarrage de TB
Avec 1 compte imap google + OAuth2 = Fenêtres multiples au démarrage de TB
Avec l'extension Startup Master = ok (pas de fenêtre multiples au démarrage de TB)

Avec Lightning + Suppression de l'agenda Google = ok (pas de fenêtre multiples au démarrage de TB)
Avec l'extension Google Agenda Tab  = ok (pas de fenêtre multiples au démarrage de TB)
Cette extension affiche l'agenda de Google dans un onglet
Keywords: regression, regressionwindow-wanted
Whiteboard: [regression:TB38?]
A short regression range would really be helpful - from anyone who has post here and first seeing the problem in version 38
http://mozilla.github.io/mozregression/documentation/usage.html
Flags: needinfo?(mozilla)
Blocks: 1229719
I had really intended this question for L.I.A.R., j2m06...

(In reply to Wayne Mery (:wsmwk, use Needinfo for questions) from comment #15)
> A short regression range would really be helpful - from anyone who has post
> here and first seeing the problem in version 38
> http://mozilla.github.io/mozregression/documentation/usage.html

Guys/gals, this would be a good first step to getting a solution for your issue
Flags: needinfo?(sexxxenator)
Flags: needinfo?(mozilla)
Flags: needinfo?(j2m06)
Hello,
I run in the same problem with TB 38.5.1 on Mac OSX after changing my Google account to OAuth2. The dialogue for the master password pops up four times. I thought this is because I have four password protected accounts and it's related to the last TB update, as this happened at the same time when I changed Google to OAuth2. But reading this bug, it seems, this is related to the Google account. For accessing the Google IMAP store I applied the "third party application password" so OAuth2 shouldn't interrupt in any way. Using the same config without master password protection there is no problem (which don't wonder as the master password dialogue doesn't appear at all).
(In reply to Wolfgang Rosenauer [:wolfiR] from comment #0)
> I found some very old bugreports about a similar issue but nothing new since
> TB 38.0.1.
> Since my addons and my accounts did not change between TB31 and 38 I
> consider this a direct regression.
> 
> With TB31 I got one master password prompt at startup.
> With TB38.0.1 I get immediately 4 of them overlapping each other so I need
> to enter my master password four times in a row.
> 
> I have 3 IMAP accounts, 2 NNTP and 1 XMPP on that system.

Do you still see these multiple prompts? 
And are any of them gmail accounts?
Flags: needinfo?(mozilla)
I still have that issue with 38.7. And I have a GMail account configured but only for XMPP/Google Talk.
Flags: needinfo?(mozilla)
Yes, with 38.6.0 on Mac OSX the problem is still problem. Prompts for the master password appear as many times as accounts with passwords are set up. On a system with the same accounts but no master password is set to unlock the accounts, there are no problems. Seem's the issue is in unlocking the password data base.
I still see this on TB 28.6.0.  I'm not using Gmail in TB. I am using the Lightning calendar, and I believe that is what is causing the dual password prompting for me. I use a master password.
Depends on: 643265
OS: Linux → All
Blocks: 1277497
Sorry for cross-posting (584014)
Hi there,
Am experiencing similar problem. 
TB 52.1.1. Release update channel, I update within a few days of being prompted. Three add-ons: Lightning, Provider for Google Calendar, Dictionnaire français "classique".
TB is configured for four addresses. I get four Master password prompts each time I launch TB. The prompts appear in the same position rapidly one after the other. I type the pw in the prompt that has the focus (i.e. the last one to show). Weirdly, the correct pwd is refused, the prompt comes up again and when I type the correct pwd a second time it's accepted. The other three prompts can then be closed using Esc.
This started happening a couple of months ago (probably after an update but I couldn't sware to that!) A bit of a bind. I use hibernation extensively, which minimizes the problem since I often only have to relaunch TB after an update.
I tried changing the pwd but that didn't help.
Wolfgang, Markus,
Please check this when 52.2.0 comes out.  
(or the current beta channel at http://www.mozilla.org/en-US/thunderbird/channel/ )
Flags: needinfo?(sexxxenator)
Flags: needinfo?(public)
Flags: needinfo?(mozilla)
Flags: needinfo?(j2m06)
Checked with 52.2.0 now and unfortunately exactly the same wrong behaviour as before.
Flags: needinfo?(mozilla)
Running 52.2.0 and have the same issue.  Multiple password prompts - add-ons are below:

Adblock Plus
Awesome Auto Archive
Enigmail
Google Search
keyconfig
Lightning
Lightning calendar tabs
LookOut
Provider for Google Calendar
Simple Search-For Extension
(In reply to Wayne Mery (:wsmwk, NI for questions) from comment #28)
> Wolfgang, Markus,
> Please check this when 52.2.0 comes out.  
> (or the current beta channel at
> http://www.mozilla.org/en-US/thunderbird/channel/ )

Unfortunately still same behaviour with 52.2.0 from the release channel.

3 IMAP accounts (but NO OAuth)
Lightning (but NO Google Calendar)
3 Master password prompts (if StartupMaster Addon disabled)
Flags: needinfo?(public)
I'm now at TB v52.2.1 (32 bit on 64 bit Win 10 v1703 latest updates applied). With 4 pop3 accounts, Google calendar via Lightening and Provider for Google Calendar (as well as DictionarySearch, FoxClocks, Mail Merge, QuoteCollapse and Recover deleted messages). With StartupMaster now disabled, I am finally getting just one prompt for the master password from TB. Thanks for all who worked on this. My issue is now solved, though it appears others are still seeing it.
Something like 1 or 2 weeks ago I got an update for thunderbird, and all of the sudden I only had 1 instead of 9 prompts. I was happy and I thought it was fixed. Then within days I got another update, and I was back to 9 prompts once more. I am currently on 52.2.1 32 bit on a 64 bit Windows 7 laptop, but I don't know what version number the temporary working version had because I didn't expect the bug to come back so soon. I hope this info helps finding the bug!
bug 1176399 was backed out of releases. So, yes, the multiple password prompts issue has returned. And presently there is not ETA for resolving this.
I spoke too soon. Something kept bugging me that I'd forgotten something I'd done to make this issue go away beside using StartupMaster, which I've always felt was a poor solution for TB. What I'd done was changed each e-mail account in TB so that under Server Settings, the "Check for new messages at startup" box was unchecked. I just unchecked that box for all my TB accounts, and sure enough, I'm now getting multiple prompts for the master password. So, problem is still unfixed for me. I'm back to my work-around and unchecking that box in all accounts again.
By the way, having TB NOT check for messages at startup is a completely acceptable solution for me. I have the mail account servers set to check for mail every 5 minutes, so at most I'm only 5 minutes from getting any new mail. Because there is no check on startup, I only get one master password prompt when starting TB. I normally only restart TB after a reboot, so it's really not a big deal for me. Of course others have other needs for which this solution is unacceptable.
I'm going to look at this, specifically the "multiple IMAP, but no OAuth" case...
Assignee: nobody → jsbruner
Status: NEW → ASSIGNED
I couldn't reproduce a situation where the password prompt would occur multiple times when I didn't use *something* from Google (OAuth). Therefore, I would prefer to fix bug 1176399 for now.
Assignee: jsbruner → nobody
Status: ASSIGNED → NEW
Depends on: 1176399
Fixed for me in 52.9.1 (64-bit)
Fixed for me as well - 52.9.1 (32-bit) - Sweet!
Still an issue on latest TB 60.0 build 20180731173940 (32-bit).  Multiple master password prompts overlay each other for each account (5 in my case).  You can enter the master password once, and then simply click "OK" on the other 4 windows.  Irritating that this has been a problem for years.
Just for your info, I'm helping a user who has been seeing this issue since Thunderbird 10 and still does with 52.9.1 on Ubuntu 18.04.1. User currently has one Google account, two CalDav accounts and two IMAP accounts.

Launchpad bug report: https://bugs.launchpad.net/bugs/940631
Patches are coming in a week or two via 60.1.0 (not 60.0) which will help the vast majority of users. Most users are still on 52.x which is not yet updating to version 60, so to get the 60.1.0 fix you will want to download the installer from https://getthunderbird.com  (Users who install from linux distro might be delayed)  Note: some add-on may not work - see https://support.mozilla.org/en-US/kb/new-thunderbird-60#w_some-add-ons-may-not-work

(Those who got relief in version 52.x can count themselves lucky.)

Please tell us your situation now, when running a newer version of Thunderbird.

Flags: needinfo?(tajkkj)
Flags: needinfo?(public)
Flags: needinfo?(mozilla)
Flags: needinfo?(bugs)

Currently running 60.4.0 on Linux

The problem persists and gets worse with every account that is added. Currently, I get 6 prompts when starting TB.
6 is the exact number of authentications it needs to perform:

3 IMAP accounts
1 CalDav calendar
2 CarDav address books

As before, only one actually needs to be filled in correctly, the others can be cancelled.
None of the accounts uses OAuth.

I think that without the StartupMaster extension I would not be using TB anymore.

Flags: needinfo?(public)

Hi all, and Wayne in particular,
Running 60.5 on Windows 10. I've not experienced this problem for several months. Well done!

Still issue. 60.5.0 on Windows and OSX. Multiple logins required.

Running 60.5.0 on Windows 10, no longer have this problem

(In reply to Wayne Mery (:wsmwk) from comment #45)

Please tell us your situation now, when running a newer version of Thunderbird.

Wayne, I just tried restarting TB with all account server settings having the "Check for new messages at startup" box checked. My work-around to this problem had been to have this box unchecked so only the Google calendar would be prompting for my TB password. With this box checked now for all accounts, messages are checked for all accounts at startup and I'm only getting one password prompt.

So, works for me on TB 60.5.0.

Flags: needinfo?(tajkkj)

On Linux with 60.5.0 I still get a bunch of authorization requests at startup.

Flags: needinfo?(mozilla)

Still a problem on 60.4.0 (Ubuntu 18.04.1)

There is one master password request per google-related thing - cardbook plugin for carddav, calendar - plus an extra one.

Cancelling the first master password box results in the error:

[Exception... "User canceled master password entry" nsresult: "0x80004004 (NS_ERROR_ABORT)" location: "JS frame :: jar:file:///usr/lib/thunderbird/omni.ja!/components/crypto-SDR.js :: decrypt :: line 177" data: no]

Correction to #52:

Cardbook plugin is NOT used with a google account.

I've never seen this issue myself but none of the users that I reported this problem for have responded to my request for an update. So nothing to add at this stage.

Flags: needinfo?(bugs)
Severity: major → normal

Seems we can close this WFM.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME

Why is this WFM?
I still have this issue with 60.8 at least.
I also wrote this in comment 51 and it seems I'm the actual reporter. It certainly does not WFM. Whatever information you like to have I can try got give.

Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Summary: multiple master password prompts since TB 38 → multiple master password prompts since TB 38 (still in 60)

I just tested this in my Thunderbird 60.8.0 on Ubuntu 18.04.2 LTS with an IMAP Gmail account.

With all 3 server settings enabled I was prompted 3 times to enter the Master Password.

I changed the Gmail accounts Server Setting to not check for any messages, quit and restarted TB. That reduced the Master Password prompt to only once.

Set the setting to "Allow immediate server notifications when new messages arrive", quit and restarted TB. Only got prompted once.

Disabled the above setting and enabled "Check for new messages at startup", quit and restarted TB. Again only one prompt.

Added "Check for messages every 10 minutes" to the mix, quit and restarted TB. Again only one prompt.

Enabled all 3 settings again, quit and restarted TB. This time I was only prompted once.

My Gmail IMAP account has SSL/TLS connection security and OAuth2 authentication method.

I also have Google Calendars using the Provider for Google Calendars extension, but that doesn't appear to trigger the prompt

Reporter, have you tried changing any of those settings in all of your IMAP accounts and testing?

Flags: needinfo?(mozilla)

Fixed for me on 60.9.0+build1-0ubuntu0.18.04.1 according to apt policy thunderbird

When starting multiple network actions in parallel, more than one might require access to the saved logins. And if the secure password store hasn't yet been unlocked with the master password, then each of those parallel actions might trigger a request to unlock it.

The only way to fix this reliably is to implement something smart at the code layer that brings up the master password prompt, which is in mozilla/security/manager.

That code would have to prevent the race, by detecting if the first prompt has already been opened, and all consecutive requests would have to be put on hold, as long as the first prompt is shown or retrying. After the prompt has been completed or canceled, all queued up requests to unlock must be signaled to continue.

(In reply to Kai Engert (:KaiE:) from comment #59)

That code would have to prevent the race, by detecting if the first prompt has already been opened, and all consecutive requests would have to be put on hold, as long as the first prompt is shown or retrying. After the prompt has been completed or canceled, all queued up requests to unlock must be signaled to continue.

I found that this approach is unlikely to work, as described in bug 177175 comment 384 (which also describes an alternative approach, which is more work, and requires changes to login manager).

See Also: → https://bugzilla.mozilla.org/show_bug.cgi?id=177175

I was reading in Bug 1361838 comment 2 that .uiBusy == true might be suitable for mitigating the issue

(In reply to Matt from comment #61)

I was reading in Bug 1361838#c2 that .uiBusy == true might be suitable for mitigating the issue

As I understand it, that's simply a flag that can be queried, whether the MP dialog is currently shown.

Detecting this state is only part of the problem. You still need to change all places that obtain logins to query for that state, and try again at a later time, if busy.

Instead of "query is MP prompt currently shown", the potential approach to change "give me the login" to return a "would block" state might be better, as it can prevent a race. (E.g. code queries if MP is shown, gets reply "no", decides to query for login, but in the meantime another thread has triggered the MP. This could still result in two MP prompts being shown.)

Flags: needinfo?(mozilla)

I confirm the same issue in Thunderbird 68.6.0

I have the same issue in Thunderbird 78.1.1

I am using several calendars in Lightning. And I am getting a "master password" Request for every single calendar, they open up right at start of Thunderbird, behind each other. If I enter my password in the first requester I can just click "OK" on the other ~10 requesters one by one and everything will work.

VERY annoying.

(In reply to Oliver from comment #64)

I have the same issue in Thunderbird 78.1.1

Your issue is a regression of a more recent change and therefore not actionable in this bug, but it is known and being addressed in bug 1664016.
p.s. it's normally only necessary to report your issue once, rather than in multiple bug reports.

This has raised its ugly head again in TB 81.0b3. Running on MacOS Mojave.

James: bug 1664016.

I think this bug should really be closed by now.

WolfIR, what is your most recent experience with version 68?

(In reply to Magnus Melin [:mkmelin] from comment #67)

I think this bug should really be closed by now.

Unfortunately it is unclear, partly because it keeps getting broken over the years. The currently blocking bugs are all fixed. But toolkit bug 177175 is not closed.

Let's close comments so newer version users don't accidentally post here.

Flags: needinfo?(mozilla)
Restrict Comments: true

I still had the issue with version 68.x
Now finally with version 78.2.2 (which I'm running currently) it seems gone.

Flags: needinfo?(mozilla)

WolfIiR thanks for the update. So we can finally close this :)

Thanks everyone for helping and sharing. If anyone still sees this problem with 78.2.2 or newer, please file a new bug report.

Status: REOPENED → RESOLVED
Closed: 5 years ago → 4 years ago
Resolution: --- → WORKSFORME

where do I get 81.0b4 for a mac with this fix?

81.0b4 will be out in a day or a few

Not fixed in 81.0b4 on a mac

If you're on macOS, our workaround from bug 1610390 is not enabled because of bug 1612456.

There used to be an addon that fixed this, but not sure it is still there, and forget the name. But please, Mac users need a fix too.

You need to log in before you can comment on or make changes to this bug.