Evan Tseng [:evanxd] Assignee
	Description • 9 years ago

We need to add AudioChannelController for InputWindow app, like keyboard app. Then the audio channel of keyboard app will be managed in AudioChannelService.

	Evan Tseng [:evanxd] Assignee
	Comment 2 • 9 years ago

CI for the patch in Comment 1: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=0c0fea80b14394d0c05f67d202e3ce0f30a06ce7

	Evan Tseng [:evanxd] Assignee
	Comment 3 • 9 years ago

Comment on attachment 8631485 [details]
[gaia] evanxd:bug-1180614 > mozilla-b2g:master

Hi Dominic,

Could you help to review the patch?

Thanks.

	Evan Tseng [:evanxd] Assignee
	Comment 4 • 9 years ago

CI: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=051ee0c30d4ff86b168838ff29b184f53f53aa92

	Naoki Hirata :nhirata (please use needinfo instead of cc)
	Comment 5 • 9 years ago

Uh.  The pref is just turned off...  If you turn it back on you have the click sound.
Is this something other than this?

Settings -> keyboards -> Built-in keyboard -> Click sound

We turned it off by default because it was annoying.

	Naoki Hirata :nhirata (please use needinfo instead of cc)
	Comment 6 • 9 years ago

Oh, this is something slightly different?
Also there's bug 1183033.  Is that related?

	Evan Tseng [:evanxd] Assignee
	Comment 7 • 9 years ago

There (In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #5)
> Uh.  The pref is just turned off...  If you turn it back on you have the
> click sound.
> Is this something other than this?
> 
> Settings -> keyboards -> Built-in keyboard -> Click sound
> 
> We turned it off by default because it was annoying.
This issue will be happened after bug 1113086 is landed. We created a new audio channel management architecture in bug 1113086 and bug 1100822. So this bug is a regression bug.

For bug 1183033, it's the root cause for gecko part. And bug 1180614 is about gaia part.

	Dominic Kuo [:dkuo]
	Comment 8 • 9 years ago

Comment on attachment 8631485 [details]
[gaia] evanxd:bug-1180614 > mozilla-b2g:master

Since the input window inherited the app window, audio channel controller(ACC) is also inherited by the input window, so this patch should just allow the input to play the keyboard sounds.

	Evan Tseng [:evanxd] Assignee
	Comment 9 • 9 years ago

Dominic, thanks for the review.

	Evan Tseng [:evanxd] Assignee
	Comment 10 • 9 years ago

master: https://github.com/mozilla-b2g/gaia/commit/794aa174dd9aa2dffa23ce21a8da52ecc4b3cde3

	Martin Shuman [:Marty]
	Comment 11 • 9 years ago

This issue is verified fixed on the latest Flame and Aries 2.5 Master build.
Keyboard click sounds are audible, and play properly. 

Environmental Variables:
Device: Aries 2.5
BuildID: 20151026111709
Gaia: a677ddd3aa3a81058775938bd56008d96dbc78b0
Gecko: 5ca03a00d26823ce91ee0eaa2937bed605bd53c1
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 44.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Environmental Variables:
Device: Flame 2.5
BuildID: 20151026030217
Gaia: a677ddd3aa3a81058775938bd56008d96dbc78b0
Gecko: 5ca03a00d26823ce91ee0eaa2937bed605bd53c1
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 44.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0