We should have the byte size of the newly tenured object in the tenure promotions log.

Comment on attachment 8632591 [details] [diff] [review] Part 0: Document the size property of entries in the tenure promotions log Review of attachment 8632591 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/doc/Debugger/Debugger.Memory.md @@ +303,5 @@ > `[[Class]]` property, for example "Array", "Date", "RegExp", or (most > commonly) "Object". > > + * *byteSize* is the size of the newly tenured object (within the tenured > + heap, not the nursery) in bytes. Maybe point out that this doesn't include any non-GC (malloced) memory that the object might hold onto?

Comment on attachment 8632592 [details] [diff] [review] Part 1: Add the size of the tenured object to the tenure promotions log entry Review of attachment 8632592 [details] [diff] [review]: ----------------------------------------------------------------- Oops. Ignore my comment on the previous patch, since it is incorrect. (It appears that ubi::Node's stuff *does* include malloced memory.) Though that makes me wonder if users of this might be interested in both? (For instance, if you are looking at how many objects you can allocate before filling up the nursery and triggering a minor GC, you don't want malloced memory included.)

Comment on attachment 8632593 [details] [diff] [review] Part 2: Test the size property of entries in the tenure promotions log Review of attachment 8632593 [details] [diff] [review]: ----------------------------------------------------------------- Nice test, though I suppose it doesn't guarantee that all of those things will get nursery-allocated in the first place. Do you want it to?

I don't think the test needs to guarantee that (and not all of them do, probably). Just wanted a variety of objects to ensure that we can handle them all if/when they do appear in the logs. Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ea832514f086

https://hg.mozilla.org/integration/mozilla-inbound/rev/c2853fd10127 https://hg.mozilla.org/integration/mozilla-inbound/rev/19817a9103a7 https://hg.mozilla.org/integration/mozilla-inbound/rev/3999da0ba5c9

https://hg.mozilla.org/mozilla-central/rev/c2853fd10127 https://hg.mozilla.org/mozilla-central/rev/19817a9103a7 https://hg.mozilla.org/mozilla-central/rev/3999da0ba5c9