Closed
Bug 1180790
Opened 9 years ago
Closed 9 years ago
Stop resetting the client id on FHR opt-out
Categories
(Firefox Health Report Graveyard :: Client: Desktop, defect, P1)
Firefox Health Report Graveyard
Client: Desktop
Tracking
(firefox40 wontfix, firefox41+ verified, firefox42 fixed)
RESOLVED
FIXED
Firefox 42
People
(Reporter: gfritzsche, Assigned: Dexter)
References
Details
(Whiteboard: [rC] [unifiedTelemetry] [uplift3])
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
gfritzsche
:
review+
ritu
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
With the system changes for unified Telemetry, we won't reset the client id anymore. This change is reasonable privacy-wise as we already persist historical ping data with the client id on disk. Now, if/while we hold back unified Telemetry from release, we should avoid corner-case and data inconsistencies by stopping FHR/DRS to reset the saved client id.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → alessio.placitelli
Updated•9 years ago
|
Priority: -- → P1
Assignee | ||
Comment 1•9 years ago
|
||
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3c512b904238
Attachment #8631524 -
Flags: review?(gfritzsche)
Reporter | ||
Comment 2•9 years ago
|
||
Comment on attachment 8631524 [details] [diff] [review] bug1180790.patch Review of attachment 8631524 [details] [diff] [review]: ----------------------------------------------------------------- I see some more - now unused - code related to this: https://dxr.mozilla.org/mozilla-central/search?q=resetClientID ::: services/healthreport/tests/xpcshell/test_healthreporter.js @@ +757,5 @@ > do_check_null(reporter.lastSubmitID); > do_check_false(reporter.haveRemoteData()); > do_check_false(server.hasDocument(reporter.serverNamespace, id)); > > + // Client ID should be updated. Nit: Just "Client ID should stay the same" and drop the other comment?
Attachment #8631524 -
Flags: review?(gfritzsche)
Assignee | ||
Comment 3•9 years ago
|
||
Ouch, thanks.
Attachment #8631524 -
Attachment is obsolete: true
Attachment #8631535 -
Flags: review?(gfritzsche)
Reporter | ||
Updated•9 years ago
|
Attachment #8631535 -
Flags: review?(gfritzsche) → review+
Assignee | ||
Comment 4•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=526fc4185bb6
Reporter | ||
Updated•9 years ago
|
Whiteboard: [b5] [unifiedTelemetry] [uplift2] → [rC] [unifiedTelemetry] [uplift3]
Assignee | ||
Comment 6•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=fx-team&revision=24ea36d26155
https://hg.mozilla.org/mozilla-central/rev/24ea36d26155
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Reporter | ||
Comment 8•9 years ago
|
||
Comment on attachment 8631535 [details] [diff] [review] bug1180790.patch - v2 Approval Request Comment [Feature/regressing bug #]: This is part of the uplift3 batch for the unified Telemetry project: http://bit.ly/1TCl4r8 This is targetting 41 now and these are the last minor "feature" patches blocking shipping - any further patches will be fixes for data quality etc. with very limited scope & impact. [User impact if declined]: Unified Telemetry can't ship. This is a change needed for data consistency. [Describe test coverage new/current, TreeHerder]: This has good automated test-coverage. [Risks and why]: Low-risk, well understood change that only removes one action. [String/UUID change made/needed]: No string changes.
Attachment #8631535 -
Flags: approval-mozilla-aurora?
Reporter | ||
Updated•9 years ago
|
status-firefox40:
--- → wontfix
status-firefox41:
--- → affected
Tracked. Also, requesting QE team to verify this fix along with all other Unified Telemetry related fixes. Thanks!
tracking-firefox41:
--- → +
Flags: qe-verify+
Comment on attachment 8631535 [details] [diff] [review] bug1180790.patch - v2 Should be safe to uplift as the patch has been in m-c for a few days and the patch is mainly removing the code where clientID was being reset.
Attachment #8631535 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 12•9 years ago
|
||
Verified fixed on 41.0b8, across platforms [1] - no clientID reset encountered during our testing. [1] Mac OS X 10.10.4, Ubuntu 14.04 32-bit and Windows 7 64-bit
Updated•6 years ago
|
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•