Spun off from bug 1180643 comment 3. With only a little extra work, we can eliminate all use of physical setters for the various logical-coordinate classes, and then remove them from the WritingModes header altogether.

These conversions seem pretty simple, but I'll push a try job to check for unexpected breakage.

Comment on attachment 8630417 [details] [diff] [review] part 2 - Remove the unused physical setter methods on logical-coordinate classes Review of attachment 8630417 [details] [diff] [review]: ----------------------------------------------------------------- ::: layout/generic/WritingModes.h @@ -673,5 @@ > CHECK_WRITING_MODE(aWritingMode); > return mPoint.y; > } > > - nscoord X(WritingMode aWritingMode, nscoord aContainerWidth) const I'm inclined to restrict the fix to removing the setters, and keep the const physical accessors even if they don't have any callers right now. @@ -682,5 @@ > - } else { > - return aWritingMode.IsBidiLTR() ? I() : aContainerWidth - I(); > - } > - } > - nscoord Y(WritingMode aWritingMode) const same here

https://hg.mozilla.org/integration/mozilla-inbound/rev/e70e937ae75b https://hg.mozilla.org/integration/mozilla-inbound/rev/e3ef946cce23

(In reply to Simon Montagu :smontagu from comment #4) > I'm inclined to restrict the fix to removing the setters, and keep the const > physical accessors even if they don't have any callers right now. Ah, right - that's what I meant to do, just got a little over-enthusiastic. :) Fixed before pushing, thanks.

https://hg.mozilla.org/mozilla-central/rev/e70e937ae75b https://hg.mozilla.org/mozilla-central/rev/e3ef946cce23