Closed
Bug 1181533
Opened 9 years ago
Closed 9 years ago
Windows build bustage in toolkit/components/downloads/nsDownloadManager.cpp with --disable-safe-browsing set
Categories
(Toolkit :: Downloads API, defect)
Toolkit
Downloads API
Tracking
()
RESOLVED
FIXED
mozilla42
Tracking | Status | |
---|---|---|
firefox42 | --- | fixed |
People
(Reporter: RyanVM, Assigned: RyanVM)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
I have --disable-parental-controls set in my .mozconfig. With bug 905127, I'm now seeing the below bustage:
toolkit/components/downloads/nsDownloadManager.cpp(84) : error C2065: 'PR_USEC_PER_MSEC' : undeclared identifier
toolkit/components/downloads/nsDownloadManager.cpp(1581) : error C3861: 'PR_Now': identifier not found
toolkit/components/downloads/nsDownloadManager.cpp(1840) : error C3861: 'PR_Now': identifier not found
toolkit/components/downloads/nsDownloadManager.cpp(2489) : error C2660: 'nsIDownloadManagerUI::Show' : function does not take 3 arguments
toolkit/components/downloads/nsDownloadManager.cpp(2489) : error C3861: 'NS_strcmp': identifier not found
toolkit/components/downloads/nsDownloadManager.cpp(2605) : error C3861: 'PR_Now': identifier not found
toolkit/components/downloads/nsDownloadManager.cpp(2724) : error C2065: 'PR_USEC_PER_MSEC' : undeclared identifier
toolkit/components/downloads/nsDownloadManager.cpp(2725) : error C3861: 'PR_Now': identifier not found
toolkit/components/downloads/nsDownloadManager.cpp(2960) : error C3861: 'PR_Now': identifier not found
toolkit/components/downloads/nsDownloadManager.cpp(2969) : error C2065: 'PR_USEC_PER_SEC' : undeclared identifier
toolkit/components/downloads/nsDownloadManager.cpp(3097) : error C3861: 'PR_Now': identifier not found
I've verified that commenting out the disable allows it to build successfully again.
Flags: needinfo?(dd.mozilla)
Assignee | ||
Comment 1•9 years ago
|
||
Gah, that should have been --disable-safe-browsing. I wonder if this is a unified build issue.
Summary: Windows build bustage in toolkit/components/downloads/nsDownloadManager.cpp with parental controls disabled → Windows build bustage in toolkit/components/downloads/nsDownloadManager.cpp with --disable-safe-browsing set
Assignee | ||
Comment 2•9 years ago
|
||
Changing the moz.build entry for nsDownloadManager.cpp from UNIFIED_SOURCES to SOURCES didn't work.
Assignee | ||
Comment 3•9 years ago
|
||
When bug 905127 landed, it added the prtime.h include to nsDownloadScanner.cpp but not nsDownloadManager.cpp. I'm guessing it got missed due to some random unified build combo that is getting tickled by my disabling of safe browsing locally.
With that, I'm down to only 2 errors:
toolkit/components/downloads/nsDownloadManager.cpp(2489) : error C2660: 'nsIDownloadManagerUI::Show' : function does not take 3 arguments
toolkit/components/downloads/nsDownloadManager.cpp(2489) : error C3861: 'NS_strcmp': identifier not found
Flags: needinfo?(dd.mozilla)
Assignee | ||
Updated•9 years ago
|
Component: Networking → Download Manager
Product: Core → Toolkit
Version: unspecified → Trunk
Assignee | ||
Comment 4•9 years ago
|
||
And nsCRTGlue.h takes care of those!
Assignee: nobody → ryanvm
Attachment #8631073 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8631081 -
Flags: review?(nfroyd)
Updated•9 years ago
|
Attachment #8631081 -
Flags: review?(nfroyd) → review+
Assignee | ||
Comment 6•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•