Closed Bug 1181644 Opened 9 years ago Closed 7 years ago

search suggestions in the awesome bar should include local search suggestions like all other access points

Categories

(Firefox :: Search, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed

People

(Reporter: mconnor, Assigned: past)

References

Details

(Whiteboard: [partner-search][suggestions][fxsearch][consistency])

Attachments

(1 file)

We're not using suggestions from local search history, unlike searchbar/about:home/about:newtab. We should be consistent here and use the same model as all other access points. It's a relatively simple fix to adjust this. Repeating previous searches should be equally easy in the location bar as in all other access points. We've just hardcoded to 0 for some reason that doesn't appear to be in the original bug.
(In reply to Mike Connor [:mconnor] from comment #0) > We've just hardcoded to 0 for some reason that doesn't appear to be in the > original bug. Because that was not what UX or any user story called for (bug 959564)...
Flags: needinfo?(shorlander)
Search History has the potential to add more entries to a potentially crowded results set in the dropdown. It's been discussed, but it's not something that was incorporated as a requirement for a first release given the other content types that intermingle with suggest results. Definitely something to look at as an enhancement.
Severity: normal → enhancement
Priority: P1 → P3
Flags: needinfo?(shorlander)
Rank: 33
Flags: firefox-backlog+
Blocks: 1212397
Whiteboard: [partner-search][suggestions][fxsearch] → [partner-search][suggestions][fxsearch][consistency]
We discussed this with product and are aiming to do this in the 57 timeframe.
Priority: P3 → P2
Bug 1359899 added a pref to do this.
Depends on: 1359899
Priority: P2 → P1
Assignee: nobody → past
Status: NEW → ASSIGNED
Discussed this at length with Javaun and we will go with 1 result for now.
Comment on attachment 8900765 [details] Bug 1181644 - Include local search suggestions in the awesomebar like all other access points. https://reviewboard.mozilla.org/r/172212/#review177488 Before landing, please check on Try for xpcshell, firefox-ui-functional and browser-chrome mochitests. While the code path is tested, we never ran the full harness with a positive value.
Attachment #8900765 - Flags: review?(mak77) → review+
Indeed, I had started a try run already and a couple of test are failing. Updated patch coming up.
LGTM!
Pushed by pastithas@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e20695873707 Include local search suggestions in the awesomebar like all other access points. r=mak
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: