Closed
Bug 1182658
Opened 9 years ago
Closed 9 years ago
Implement TraceNullableRoot so that we can simplify RootMarking
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla42
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
People
(Reporter: terrence, Assigned: terrence)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
This just does the null check internally where we have to null check unconditionally anyway. It saves us a bit of complexity and gets us closer to reifying PersistentRooted and Rooted's marking.
Attachment #8632304 -
Flags: review?(jcoppeard)
|
||
Updated•9 years ago
|
Attachment #8632304 -
Flags: review?(jcoppeard) → review+
|
Assignee | |
Comment 2•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8a220bb3a548
Note: I solved the cgc failures locally.
|
||
Comment 3•9 years ago
|
||
Is it possible that this patch somehow affected GC and is responsible for the 6% regression on Splay on Mac 32-bit on AWFY? http://arewefastyet.com/#machine=28&view=single&suite=octane&subtest=Splay
If not, it should at least be one of your other patches in the same regression range.
Flags: needinfo?(terrence)
|
||
Comment 4•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
|
|
Assignee | |
Comment 6•9 years ago
|
||
No change from backout. Relanding. Moving on to bug 1181869.
Flags: needinfo?(terrence)
|
|
Assignee | |
Comment 8•9 years ago
|
||
Backouts for bug 1182124 and bug 1181869 are also now both in AWFY: still no change. These are not the patches you are looking for.
|
||
Comment 9•9 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•