Closed
Bug 1182894
Opened 9 years ago
Closed 9 years ago
Hiding markers can hide different markers
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect)
Tracking
(firefox42 fixed)
RESOLVED
FIXED
Firefox 42
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
People
(Reporter: jsantell, Assigned: jsantell)
References
()
Details
Attachments
(1 file)
|
(deleted),
patch
|
vporof
:
review+
|
Details | Diff | Splinter Review |
Can't describe this one well, so here's a gif.
When hiding "Function Calls", all of the "DOM Events" are hidden as well except one. Most markers are DOM Events enveloping Function Calls. This is very weird.
Profile: https://bugzilla.mozilla.org/attachment.cgi?id=8625553
|
||
Comment 1•9 years ago
|
||
(In reply to Jordan Santell [:jsantell] [@jsantell] from comment #0)
> Can't describe this one well, so here's a gif.
BROKEN PROMISES
|
Assignee | |
Comment 2•9 years ago
|
||
i wish :[ attached in the URL field: http://i.imgur.com/bnbyRob.gif
|
|
Assignee | |
Comment 3•9 years ago
|
||
Looks like bug 1176537 fixes this, but need to write a test for that -- I thought we had something similar, but I guess we don't have an xpcshell test for both filtering and collapsing in one go.
Depends on: 1176537
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 4•9 years ago
|
||
Looks like that marker fix did fix this as well. Here's a test ensuring that.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9e4e06c31269
Attachment #8633849 -
Flags: review?(vporof)
|
|
||
Updated•9 years ago
|
Attachment #8633849 -
Flags: review?(vporof) → review+
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•