Closed Bug 1183235 Opened 9 years ago Closed 9 years ago

Keep the dochsell-specific markers inside a ObservedDocShell managed list instead of nsDocShell

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Product:
DevTools
Component:
Performance Tools (Profiler/Timeline)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox42 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 42
Tracking Flags:
Tracking Status
firefox42 --- fixed

People

(Reporter: vporof, Assigned: vporof)

References

Details

Attachments

(2 files, 1 obsolete file)

v1
(deleted), patch
smaug
: review+
Details | Diff | Splinter Review
v3
(deleted), patch
vporof
: review+
Details | Diff | Splinter Review
No description provided.
Attached patch v1 (deleted) — — Splinter Review
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #8634459 - Flags: review?(ttromey)
Attachment #8634459 - Flags: review?(ttromey) → review?(bugs)
Attachment #8634459 - Flags: review?(bugs) → review+
Attached patch v2 (obsolete) (deleted) — — Splinter Review
Rebased.
Attachment #8635480 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/a40f98f08e6b
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
This was backed out in: https://hg.mozilla.org/integration/fx-team/rev/fdff9c45b9c9
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch v3 (deleted) — — Splinter Review
Fixed a crash. Previously, the lifetime of mTimelineMarkers was bound to the lifetime of the nsDocShell. In this bug, that was changed to be tied to the lifetime of an ObservedDocShell, meaning they are created when recording is enabled, and destroyed when disabled. However, `nsDocShell::PopProfileTimelineMarkers` doesn't handle the latter case, and assumes an existing markers storage. Updated the patch to handle the null case.
Attachment #8635480 - Attachment is obsolete: true
Attachment #8637932 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/b245058d67aa
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: