Closed
Bug 1183606
Opened 9 years ago
Closed 8 years ago
Integrate svgo to automate SVG optimization
Categories
(Hello (Loop) :: Client, defect, P2)
Hello (Loop)
Client
Tracking
(Not tracked)
RESOLVED
INCOMPLETE
People
(Reporter: mikedeboer, Unassigned)
Details
(Whiteboard: [tech-debt][lang=Makefile|lang=shell])
For the design refresh of Hello, we'll be using a number of new SVG assets that are not delivered in their most optimal shape. The svgo tool can help remedy that and the gaia script, as linked below, shows good example usage with params that they found to work best in practice.
Link to b2g's gaia script: https://github.com/mozilla-b2g/gaia/blob/master/tools/svg_recompress.sh
Link to svgo: https://github.com/svg/svgo
Flags: qe-verify-
Flags: firefox-backlog+
Updated•9 years ago
|
Rank: 35
Priority: -- → P3
Comment 2•9 years ago
|
||
Now we're in github (https://github.com/mozilla/loop) we should do this.
In the Makefile, we'll need to adjust the add-on, standalone and ui targets to not blanket-copy the shared and standalone directories, but copy the the sub-directories individually.
Then, for the image directories, we can set up dependencies for svg and pngs - the .pngs should just be copied across, the svg files should be run through svgo (use default config for now).
svgo is available here: https://github.com/svg/svgo - we should use the node version of it, updating package.json for the specific version, and using $(NODE_LOCAL_BIN)/svgo in the Makefile to reference it.
Mentor: standard8
Rank: 35 → 32
Whiteboard: [tech-debt] → [tech-debt][lang=Makefile]
Updated•9 years ago
|
Whiteboard: [tech-debt][lang=Makefile] → [tech-debt][lang=Makefile|lang=shell]
Updated•9 years ago
|
Rank: 32 → 28
Priority: P3 → P2
Updated•8 years ago
|
Mentor: standard8
Comment 3•8 years ago
|
||
Support for Hello/Loop has been discontinued.
https://support.mozilla.org/kb/hello-status
Hence closing the old bugs. Thank you for your support.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INCOMPLETE
You need to log in
before you can comment on or make changes to this bug.
Description
•