Closed
Bug 118368
Opened 23 years ago
Closed 23 years ago
Menus and tooltips need drop shadow on WinXP
Categories
(Core :: XUL, defect)
Tracking
()
RESOLVED
FIXED
mozilla0.9.8
People
(Reporter: hyatt, Assigned: hyatt)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
bryner
:
review+
bugzilla
:
superreview+
|
Details | Diff | Splinter Review |
This bug covers registering and using the appropriate window class for popups
and tooltips that should have drop shadows under WinXP.
|
Assignee | |
Updated•23 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.8
|
|
Assignee | |
Comment 1•23 years ago
|
||
|
|
Assignee | |
Comment 2•23 years ago
|
||
Ready for r/sr. Rod, could you review? Hewitt, could you super-review?
Thanks!
|
||
Comment 3•23 years ago
|
||
Comment on attachment 63679 [details] [diff] [review]
Patch that adds drop shadow support to all XUL popups except menu lists.
sr=blake
(remove those spaces you added)
Attachment #63679 -
Flags: superreview+
|
|
||
Comment 4•23 years ago
|
||
Seems like "MozillaDropShadowWindowClass" could use a more generic name
(MozillaPopupWindowClass?) since for non-XP flavors there won't be a drop
shadow. (Can you say 'nit'?)
|
||
Comment 5•23 years ago
|
||
See bug 118379 for a long term solution to the hardcoded element name problem.
Blocks: 118379
|
||
Comment 6•23 years ago
|
||
Comment on attachment 63679 [details] [diff] [review]
Patch that adds drop shadow support to all XUL popups except menu lists.
r=bryner
Attachment #63679 -
Flags: review+
|
|
Assignee | |
Comment 7•23 years ago
|
||
Ok, I'm landing this. Rods, if you see anything objectionable let me know, and
I'll patch it (or back it out if need be).
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•23 years ago
|
OS: Windows 2000 → Windows XP
Component: XP Toolkit/Widgets: Menus → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
You need to log in
before you can comment on or make changes to this bug.
Description
•