Closed
Bug 1183730
Opened 9 years ago
Closed 9 years ago
Sync migration warning icon not displayed properly in Hamburger menu
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
Firefox 42
People
(Reporter: eoger, Assigned: eoger)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
markh
:
review+
ritu
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
The warning icon is not displayed because we didn't update the CSS rules
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8633578 -
Flags: review?(markh)
Assignee | ||
Updated•9 years ago
|
Summary: Migration warning icon not displayed properly → Sync migration warning icon not displayed properly in Hamburger menu
Assignee | ||
Comment 2•9 years ago
|
||
And we also had a typo in one of the images path!
Attachment #8633578 -
Attachment is obsolete: true
Attachment #8633578 -
Flags: review?(markh)
Attachment #8633582 -
Flags: review?(markh)
Updated•9 years ago
|
Attachment #8633582 -
Flags: review?(markh) → review+
Updated•9 years ago
|
status-firefox39:
--- → wontfix
status-firefox40:
--- → affected
status-firefox41:
--- → affected
status-firefox42:
--- → affected
Keywords: checkin-needed
Keywords: checkin-needed
Comment 4•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Comment 5•9 years ago
|
||
Comment on attachment 8633582 [details] [diff] [review]
bug-1183730.patch
Approval Request Comment
[Feature/regressing bug #]: 1139698
[User impact if declined]: The "warning" icon when FxA is in an error state isn't shown when it should be.
[Describe test coverage new/current, TreeHerder]: Existing tests pass
[Risks and why]: None
[String/UUID change made/needed]: None
Attachment #8633582 -
Flags: approval-mozilla-aurora?
Mark, could you please verify that this fix works for you? I would like to approve it for uplift to Aurora and since it only landed in m-c a day or two ago, if I get a "verified" from you, I can give it the green signal today. Thanks!
Flags: needinfo?(markh)
Updated•9 years ago
|
QA Contact: catalin.varga
Comment 7•9 years ago
|
||
I can't see this work on 42.0a1 (2015-07-21) for some reason. The Inspector tool also isn't showing me that ::after rules for the element and I'm not sure if this is a limitation in the inspector (I'm sure it does show them on content) or a reflection of why I can't see them.
:eoger, can you please have a look?
Flags: needinfo?(markh) → needinfo?(edouard.oger)
Comment 8•9 years ago
|
||
(In reply to Mark Hammond [:markh] from comment #7)
> Hrm - but I do see it work correctly locally built. Hopefully tomorrow's nightly will have it?
Comment 9•9 years ago
|
||
Ritu, I can verify this is working as expected on Nightly, so ni? to address the uplift request.
Flags: needinfo?(edouard.oger) → needinfo?(rkothari)
Comment on attachment 8633582 [details] [diff] [review]
bug-1183730.patch
Mark has verified the fix on nightly. Safe to land on Aurora.
Flags: needinfo?(rkothari)
Attachment #8633582 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 11•9 years ago
|
||
Comment 12•9 years ago
|
||
Setting as Verified for Nightly based on comment 9.
You need to log in
before you can comment on or make changes to this bug.
Description
•