Closed
Bug 1183867
Opened 9 years ago
Closed 9 years ago
Fix PushSubscription.unsubscribe() semantics
Categories
(Core :: DOM: Notifications, defect)
Core
DOM: Notifications
Tracking
()
RESOLVED
FIXED
mozilla42
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
People
(Reporter: nsm, Assigned: nsm)
References
Details
Attachments
(1 file)
resolve with false when subscription does not exist. true when successfully unregistered. reject with NetworkError in other cases.
|
Assignee | |
Comment 1•9 years ago
|
||
Bug 1183867 - Fix PushSubscription.unsubscribe() semantics r?mt
resolve with false when subscription does not exist. true when successfully unregistered. reject with NetworkError in other cases.
Attachment #8633722 -
Flags: review?(martin.thomson)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8633722 [details]
MozReview Request: Bug 1183867 - Fix PushSubscription.unsubscribe() semantics r?mt
https://reviewboard.mozilla.org/r/13257/#review11887
Ship It!
::: dom/push/PushService.jsm:961
(Diff revision 1)
> - ]);
> + ]).then(function() {
> + return true;
> + });
`_ => true` or `() => true`
Attachment #8633722 -
Flags: review?(martin.thomson) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
url: https://hg.mozilla.org/integration/mozilla-inbound/rev/0560abdc67cf6b249101da32ad6af4580990addb
changeset: 0560abdc67cf6b249101da32ad6af4580990addb
user: Nikhil Marathe <nsm.nikhil@gmail.com>
date: Tue Jul 14 15:01:41 2015 -0700
description:
Bug 1183867 - Fix PushSubscription.unsubscribe() semantics r=mt
resolve with false when subscription does not exist. true when successfully unregistered. reject with NetworkError in other cases.
|
||
Comment 4•9 years ago
|
||
Assignee: nobody → nsm.nikhil
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•