Closed
Bug 1184056
Opened 9 years ago
Closed 9 years ago
Reader mode check for meta-refresh should not be case-sensitive
Categories
(Toolkit :: Reader Mode, defect)
Toolkit
Reader Mode
Tracking
()
RESOLVED
FIXED
mozilla42
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
People
(Reporter: freddy, Assigned: freddy)
References
()
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
Margaret
:
review+
|
Details | Diff | Splinter Review |
> let urlIndex = content.indexOf("URL=");
Should be
> let urlIndex = content.toLowerCase().indexOf("URL=");
|
Assignee | |
Comment 1•9 years ago
|
||
toUpperCase* :)
|
|
Assignee | |
Comment 2•9 years ago
|
||
Margaret, can you take a look?
Assignee: nobody → fbraun
Status: NEW → ASSIGNED
Attachment #8634021 -
Flags: review?(margaret.leibovic)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8634021 [details] [diff] [review]
bug-1184056-reader-mode-redirect.v1.patch
Review of attachment 8634021 [details] [diff] [review]:
-----------------------------------------------------------------
::: toolkit/components/reader/ReaderMode.jsm
@@ +206,4 @@
> if (meta) {
> let content = meta.getAttribute("content");
> if (content) {
> + let urlIndex = content.toUpperCase().indexOf("L=");
Why just "L=" and not "URL="?
|
|
Assignee | |
Comment 4•9 years ago
|
||
My Apologies...this one looks a bit better to me.
Attachment #8634021 -
Attachment is obsolete: true
Attachment #8634021 -
Flags: review?(margaret.leibovic)
Attachment #8634179 -
Flags: review?(margaret.leibovic)
|
|
||
Comment 5•9 years ago
|
||
Comment on attachment 8634179 [details] [diff] [review]
bug-1184056-reader-mode-redirect.v1.patch
Review of attachment 8634179 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good, thanks.
Attachment #8634179 -
Flags: review?(margaret.leibovic) → review+
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
|
||
Comment 7•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•