Closed Bug 1184074 Opened 9 years ago Closed 9 years ago

window.open(..., '_blank') is broken on b2g

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

All
Gonk (Firefox OS)
defect
Not set
blocker

Tracking

(blocking-b2g:2.5+, firefox42 affected)

RESOLVED DUPLICATE of bug 1183301
blocking-b2g 2.5+
Tracking Status
firefox42 --- affected

People

(Reporter: cwiiis, Unassigned)

References

Details

(Keywords: regression)

As the summary says. Running that seems to result in a bunch of work being done (as the device heats up and stops responding in as timely a manner), but no window is shown.

This completely breaks many common interactions.
A bisection says this was caused by patch 1 from bug 1113086.
Blocks: 1113086
Flags: needinfo?(amarchesini)
It looks like this is happening because the interface has changed and Gaia system hasn't been updated.

Specifically, an exception is happening in gaia/apps/system/js/app_window.js:865:

[JavaScript Error: "InvalidNodeTypeError: The supplied node is incorrect or has an incorrect ancestor for this operation." {file: "app://system.gaiamobile.org/js/app_window.js" line: 865}]
Component: DOM: Core & HTML → Gaia::System
Product: Core → Firefox OS
Version: Trunk → unspecified
[Blocking Requested - why for this release]:
blocking-b2g: --- → 2.5?
Sorry, forgot to fill out reason... Kind of obvious though - you can't open new windows with this regression. Clicking on any link that opens in a new window, unless it's a remote window, results in failure.
I might've been hasty changing the component - it doesn't seem that the API has changed, just that this line now fails in the situation of opening a new non-remote window: https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/app_window.js#L855 (var audioChannels = this.browser.element.allowedAudioChannels;)
I don't know what the right fix for this should be, but here's a quick work-around for anyone else whose work this is blocking: https://gist.github.com/Cwiiis/e3279ebf6429cbd56027
Alastor, is this a duplicate? You already fix this, correct?
Flags: needinfo?(amarchesini) → needinfo?(alwu)
Yes, it's the same issue.
I would update the patch to fix it.
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: needinfo?(alwu)
Resolution: --- → DUPLICATE
blocking-b2g: 2.5? → 2.5+
I reported similar problem in bug 1238511.

So I think it's not resolved.
I think that is different issue, it should be discussed in another bug.
You need to log in before you can comment on or make changes to this bug.