This is follow up for bug 1172716 STR: 1) apply patch, build, start Firefox 2) open the settings app 3) search for "font" 4) click the "Make text and other items larger or smaller" item 5) in the "Change the text size only" section, change the messagebox size to 14 6) wait for Windows to do whatever it's doing 7) sadness as your buttons no longer match up to your urlbar. Honza

This is how the bug looks like on Windows 10 (with DevEdition theme) Honza

Philipp, what is the right fix here, make the height of the buttons the same as: a) The other buttons on the right side of the URL & search bar? b) The URL & search bar? The attached screenshot shows (a) Honza

(In reply to Jan Honza Odvarko [:Honza] from comment #2) > Created attachment 8634056 [details] > bug1184097-possible-fix.png > > Philipp, what is the right fix here, make the height of the buttons the same > as: > a) The other buttons on the right side of the URL & search bar? > b) The URL & search bar? > > The attached screenshot shows (a) > > Honza The buttons should have the same height as the location bar. One thing to keep in mind there: this should *not* make the icons stretch. They should just stay centered inside the now slightly larger button. FWIW, the non-dev-edition version of Firefox for Windows 10 has also increased the height of other toolbar buttons to match the height of the location bar and search field.

(In reply to Philipp Sackl [:phlsa] please use needinfo from comment #3) > (In reply to Jan Honza Odvarko [:Honza] from comment #2) > > Created attachment 8634056 [details] > > bug1184097-possible-fix.png > > > > Philipp, what is the right fix here, make the height of the buttons the same > > as: > > a) The other buttons on the right side of the URL & search bar? > > b) The URL & search bar? > > > > The attached screenshot shows (a) > > > > Honza > > The buttons should have the same height as the location bar. One thing to > keep in mind there: this should *not* make the icons stretch. They should > just stay centered inside the now slightly larger button. > FWIW, the non-dev-edition version of Firefox for Windows 10 has also > increased the height of other toolbar buttons to match the height of the > location bar and search field. Note that the buttons on the right side of the location and search bar don't match the height if system font-size is increased. Is that correct behavior? Btw. the location bar seems to be broken too in such case. See the attached screenshot. Honza

The location bar truly looks broken in this case. How did you adjust the font size here? When I set it through the system scaling options (»Scale text, apps...«) this doesn't happen for me.

(In reply to Philipp Sackl [:phlsa] please use needinfo from comment #5) > The location bar truly looks broken in this case. > How did you adjust the font size here? When I set it through the system > scaling options (»Scale text, apps...«) this doesn't happen for me. This is using the individual text sizing options.

Yep, scaling forks for me too. The comment #0 has STR how to change the font size. Honza

I am still a bit unsure how the height of the buttons should reflect the height of the system font-size. I am attaching a screenshot that shows: A) back/fwd buttons match the size of the location & search bar (default system font-size) B) back/fwd buttons match the size of the other buttons in the toolbar - they have the same height as in non-devedition theme (default system font-size increased to 24) Does it make sense? Honza

NI for comment #8 Honza

Sorry for the delay... I think scaling with the size of the URL bar would make more sense since the buttons generally look like they are attached to that bar.

Is a fix going to affect all OSes? We are seeing what looks to be the same problem in OSX in Bug 1189410.

I don't think Bug 1172716 could have caused this issue on OSX, so maybe this originally regressed from a different bug.

(In reply to Brian Grinstead [:bgrins] from comment #11) > Is a fix going to affect all OSes? We are seeing what looks to be the same > problem in OSX in Bug 1189410. I don't know I wasn't able to figure out how to force the buttons to follow height of the URL bar using CSS. Perhaps JS based computation is needed? > I don't think Bug 1172716 could have caused this issue on OSX, so maybe this > originally regressed from a different bug. Bug 1172716 isn't the culprit I was experiencing the problem already before. Honza

Tracked down the regression for Bug 1189410 (which is quite possibly the same as this one, but I'm not positive since this seems to require changing system font size). It was caused by Bug 1185362

Please re-open if this crops up again but I believe it was fixed in another bug.