Closed Bug 1184180 Opened 9 years ago Closed 9 years ago

Add support to toggle display "shade"

Categories

(Firefox OS Graveyard :: Gaia::System::Accessibility, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System::Accessibility
Platform:
All
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(feature-b2g:2.2r+, b2g-v2.2r fixed, b2g-master fixed)

Status:
RESOLVED FIXED
Project Flags:
feature-b2g 2.2r+
Tracking Flags:
Tracking Status
b2g-v2.2r --- fixed
b2g-master --- fixed

People

(Reporter: eeejay, Assigned: eeejay)

References

Details

(Keywords: access)

Attachments

(2 files)

[gaia] eeejay:bug-1184180 > mozilla-b2g:master
(deleted), text/x-github-pull-request
timdream
: review+
Details
[gaia] eeejay:bug-1184180-v22r > mozilla-b2g:v2.2r
(deleted), text/x-github-pull-request
Details
Screen reader users should enjoy the fact that they don't need the screen to be physically on during normal operation. This conserves battery and provides privacy against people looking over the user's shoulder.
Comment on attachment 8635431 [details] [gaia] eeejay:bug-1184180 > mozilla-b2g:master This keeps most of the logic in the accessibility module and adds a new state in the screen manager that overrides the users brightness and forces it to 0 when the shade is toggled.
Attachment #8635431 - Flags: review?(timdream)
Comment on attachment 8635431 [details] [gaia] eeejay:bug-1184180 > mozilla-b2g:master I don't think ScreenManager is in good shape to pile feature on -- it's unit tests are probably never cover everything in full, but, if you are adventurous I won't stop you on that -- just to make sure you leave a lot of time for possible regressions.
Attachment #8635431 - Flags: review?(timdream) → review+
I'll take the chance. Better regressions sooner than later!
https://github.com/mozilla-b2g/gaia/commit/8502d07cd7e68da79303471acf64eea48b3dce24
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Could you upload this patch to v2.2r?
Flags: needinfo?(eitan)
I would like to. There is a set of patches. What is the landing procedure for v2.2r. Who do I ask for approval?
Flags: needinfo?(eitan) → needinfo?(whuang)
At the current stage there's no approval flag needed to uplift to 2.2R. I just set the checkin-needed and feature-b2g:2.2r+ so that releng will follow up. Please refer to [1]. [1] https://wiki.mozilla.org/Release_Management/FirefoxOS/2_2_R_Schedule#Patch_Uplifts
feature-b2g: --- → 2.2r+
Flags: needinfo?(whuang)
Keywords: checkin-needed
(In reply to Eitan Isaacson [:eeejay] from comment #7) > I would like to. There is a set of patches. What is the landing procedure > for v2.2r. Who do I ask for approval? Hey Eeejay could you provide a PR request and i will get this into 2.2r Thanks!
Flags: needinfo?(eitan)
Thanks, Tomcat!
Flags: needinfo?(eitan)
Rebased and tested.
We can drop checkin-needed, now, right?
Keywords: checkin-needed
Yes.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: