Closed
Bug 1184242
Opened 9 years ago
Closed 9 years ago
1,900 instances of "'aTabParent != sActiveTabParent'" emitted from dom/events/IMEStateManager.cpp during linux64 debug testing
Categories
(Core :: DOM: Events, defect)
Core
DOM: Events
Tracking
()
RESOLVED
FIXED
mozilla42
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
People
(Reporter: erahm, Assigned: erahm)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
masayuki
:
review+
|
Details | Diff | Splinter Review |
> 1913 [NNNNN] WARNING: 'aTabParent != sActiveTabParent', file dom/events/IMEStateManager.cpp, line 948
This warning [1] shows up in the following test suites:
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-3-bm118-tests1-linux64-build0.txt:718
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-1-bm53-tests1-linux64-build0.txt:496
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-2-bm67-tests1-linux64-build0.txt:313
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-1-bm123-tests1-linux64-build25.txt:190
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-5-bm52-tests1-linux64-build2.txt:69
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-4-bm122-tests1-linux64-build12.txt:39
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-2-bm53-tests1-linux64-build12.txt:33
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-3-bm51-tests1-linux64-build0.txt:30
> mozilla-central_ubuntu64_vm-debug_test-mochitest-1-bm117-tests1-linux64-build1.txt:11
> mozilla-central_ubuntu64_vm-debug_test-mochitest-5-bm115-tests1-linux64-build29.txt:4
> mozilla-central_ubuntu64_vm-debug_test-mochitest-2-bm67-tests1-linux64-build1.txt:4
> mozilla-central_ubuntu64_vm-debug_test-reftest-e10s-2-bm123-tests1-linux64-build2.txt:3
> mozilla-central_ubuntu64_vm-debug_test-reftest-e10s-1-bm68-tests1-linux64-build0.txt:3
It shows up in 698 tests. A few of the most prevalent:
> 46 - browser/base/content/test/general/browser_bug553455.js
> 23 - docshell/test/navigation/test_sessionhistory.html
> 21 - toolkit/mozapps/extensions/test/browser/browser_gmpProvider.js
> 19 - browser/components/sessionstore/test/browser_394759_behavior.js
> 16 - dom/html/test/browser_bug1108547.js
> 16 - docshell/test/navigation/test_reserved.html
> 16 - docshell/test/navigation/test_not-opener.html
> 15 - toolkit/mozapps/extensions/test/browser/browser_bug577990.js
> 14 - toolkit/mozapps/extensions/test/browser/browser_searching.js
> 13 - toolkit/components/passwordmgr/test/browser/browser_notifications.js
[1] https://hg.mozilla.org/mozilla-central/annotate/49683d4e9ebd/dom/events/IMEStateManager.cpp#l948
|
||
Comment 1•9 years ago
|
||
masayuki should comment here whether we could remove the warning.
|
Assignee | |
Comment 2•9 years ago
|
||
Masayuki, it looks like we also log an error message if this happens. Are you okay with changing the |if(NS_WARN_IF(aTabParent != sActiveTabParent))| to just an |if(aTabParent != sActiveTabParent)|?
Flags: needinfo?(masayuki)
|
||
Comment 3•9 years ago
|
||
Absolutely. Looks like that parent process sometimes received requests to set input content from child process but the requests are too late since focus was changed already. So, this must be possible case, not detecting unexpected case.
Flags: needinfo?(masayuki)
|
|
Assignee | |
Comment 4•9 years ago
|
||
Attachment #8634557 -
Flags: review?(masayuki)
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → erahm
Status: NEW → ASSIGNED
|
|
||
Comment 5•9 years ago
|
||
Comment on attachment 8634557 [details] [diff] [review]
Remove aTabParent != sActiveTabParent warning from IMEStateManager::SetInputContextForChildProcess
Thanks!
Attachment #8634557 -
Flags: review?(masayuki) → review+
|
|
Assignee | |
Comment 6•9 years ago
|
||
url: https://hg.mozilla.org/integration/mozilla-inbound/rev/7bdacc3df33dd96c63c183bb5b798b1e1d3b06a3
changeset: 7bdacc3df33dd96c63c183bb5b798b1e1d3b06a3
user: Eric Rahm <erahm@mozilla.com>
date: Wed Jul 15 22:29:18 2015 -0700
description:
Bug 1184242 - Remove aTabParent != sActiveTabParent warning from IMEStateManager::SetInputContextForChildProcess. r=masayuki
|
||
Comment 7•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•