Closed Bug 1184293 Opened 9 years ago Closed 9 years ago

2,200 instances of "NS_ENSURE_TRUE(aURI) failed" and associated warnings emitted from netwerk/dns/nsEffectiveTLDService.cpp during linux64 debug testing

Categories

(Core :: Networking: DNS, defect)

Product:
Core
Component:
Networking: DNS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla42
Tracking Flags:
Tracking Status
firefox42 --- fixed

People

(Reporter: erahm, Assigned: erahm)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Don't call ThirdPartyUtil::GetBaseDomain if aUri is null
(deleted), patch
jduell.mcbugs
: review+
Details | Diff | Splinter Review
> 1120 [NNNNN] WARNING: NS_ENSURE_TRUE(aURI) failed: file netwerk/dns/nsEffectiveTLDService.cpp, line 161 This warning [1] shows up in the following test suites: > mozilla-central_ubuntu64_vm-debug_test-mochitest-other-bm53-tests1-linux64-build0.txt:337 > mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-1-bm122-tests1-linux64-build19.txt:182 > mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-2-bm117-tests1-linux64-build8.txt:143 > mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-2-bm67-tests1-linux64-build0.txt:80 > mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-3-bm118-tests1-linux64-build0.txt:77 > mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-1-bm53-tests1-linux64-build0.txt:72 > mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-3-bm122-tests1-linux64-build17.txt:70 > mozilla-central_ubuntu64_vm-debug_test-mochitest-devtools-chrome-3-bm115-tests1-linux64-build9.txt:46 > mozilla-central_ubuntu64_vm-debug_test-mochitest-devtools-chrome-2-bm120-tests1-linux64-build0.txt:40 > mozilla-central_ubuntu64_vm-debug_test-mochitest-devtools-chrome-1-bm52-tests1-linux64-build11.txt:16 > mozilla-central_ubuntu64_vm-debug_test-mochitest-jetpack-bm123-tests1-linux64-build2.txt:11 > mozilla-central_ubuntu64_vm-debug_test-mochitest-1-bm117-tests1-linux64-build1.txt:8 > mozilla-central_ubuntu64_vm-debug_test-mochitest-4-bm121-tests1-linux64-build0.txt:7 > mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-5-bm52-tests1-linux64-build2.txt:4 > mozilla-central_ubuntu64_vm-debug_test-mochitest-3-bm115-tests1-linux64-build21.txt:4 > mozilla-central_ubuntu64_vm-debug_test-mochitest-2-bm67-tests1-linux64-build1.txt:4 > mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-2-bm53-tests1-linux64-build12.txt:3 > mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-1-bm123-tests1-linux64-build25.txt:3 > mozilla-central_ubuntu64_vm-debug_test-mochitest-devtools-chrome-4-bm51-tests1-linux64-build3.txt:3 > mozilla-central_ubuntu64_vm-debug_test-mochitest-5-bm115-tests1-linux64-build29.txt:3 > mozilla-central_ubuntu64_vm-debug_test-mochitest-push-bm68-tests1-linux64-build20.txt:2 > mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-4-bm122-tests1-linux64-build12.txt:2 > mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-3-bm51-tests1-linux64-build0.txt:2 > mozilla-central_ubuntu64_vm-debug_test-mochitest-gl-bm113-tests1-linux64-build14.txt:1 It shows up in 381 tests. A few of the most prevalent: > 144 - Shutdown > 56 - dom/manifest/test/browser_ManifestObtainer_obtain.js > 42 - toolkit/mozapps/extensions/test/browser/browser_discovery.js > 26 - caps/tests/mochitest/test_disableScript.xul > 21 - toolkit/components/url-classifier/tests/mochitest/test_classified_annotations.html > 20 - toolkit/mozapps/extensions/test/browser/browser_bug562797.js > 18 - toolkit/identity/tests/chrome/test_sandbox.xul > 18 - toolkit/components/url-classifier/tests/mochitest/test_privatebrowsing_trackingprotection.html > 15 - toolkit/components/url-classifier/tests/mochitest/test_allowlisted_annotations.html > 15 - caps/tests/mochitest/test_bug995943.xul [1] https://hg.mozilla.org/mozilla-central/annotate/49683d4e9ebd/netwerk/dns/nsEffectiveTLDService.cpp#l161
> 1120 [NNNNN] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80070057: file dom/base/ThirdPartyUtil.cpp, line 357 These warnings go hand in hand, |ThirdPartyUtil::GetBaseDomain| calls |nsEffectiveTLDService::GetBaseDomain|, both warn about NS_ERROR_INVALID_ARG. This warning [1] shows up in the following test suites: > mozilla-central_ubuntu64_vm-debug_test-mochitest-other-bm53-tests1-linux64-build0.txt:337 > mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-1-bm122-tests1-linux64-build19.txt:182 > mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-2-bm117-tests1-linux64-build8.txt:143 > mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-2-bm67-tests1-linux64-build0.txt:80 > mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-3-bm118-tests1-linux64-build0.txt:77 > mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-1-bm53-tests1-linux64-build0.txt:72 > mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-3-bm122-tests1-linux64-build17.txt:70 > mozilla-central_ubuntu64_vm-debug_test-mochitest-devtools-chrome-3-bm115-tests1-linux64-build9.txt:46 > mozilla-central_ubuntu64_vm-debug_test-mochitest-devtools-chrome-2-bm120-tests1-linux64-build0.txt:40 > mozilla-central_ubuntu64_vm-debug_test-mochitest-devtools-chrome-1-bm52-tests1-linux64-build11.txt:16 > mozilla-central_ubuntu64_vm-debug_test-mochitest-jetpack-bm123-tests1-linux64-build2.txt:11 > mozilla-central_ubuntu64_vm-debug_test-mochitest-1-bm117-tests1-linux64-build1.txt:8 > mozilla-central_ubuntu64_vm-debug_test-mochitest-4-bm121-tests1-linux64-build0.txt:7 > mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-5-bm52-tests1-linux64-build2.txt:4 > mozilla-central_ubuntu64_vm-debug_test-mochitest-3-bm115-tests1-linux64-build21.txt:4 > mozilla-central_ubuntu64_vm-debug_test-mochitest-2-bm67-tests1-linux64-build1.txt:4 > mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-2-bm53-tests1-linux64-build12.txt:3 > mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-1-bm123-tests1-linux64-build25.txt:3 > mozilla-central_ubuntu64_vm-debug_test-mochitest-devtools-chrome-4-bm51-tests1-linux64-build3.txt:3 > mozilla-central_ubuntu64_vm-debug_test-mochitest-5-bm115-tests1-linux64-build29.txt:3 > mozilla-central_ubuntu64_vm-debug_test-mochitest-push-bm68-tests1-linux64-build20.txt:2 > mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-4-bm122-tests1-linux64-build12.txt:2 > mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-3-bm51-tests1-linux64-build0.txt:2 > mozilla-central_ubuntu64_vm-debug_test-mochitest-gl-bm113-tests1-linux64-build14.txt:1 It shows up in 381 tests. A few of the most prevalent: > 144 - Shutdown > 56 - dom/manifest/test/browser_ManifestObtainer_obtain.js > 42 - toolkit/mozapps/extensions/test/browser/browser_discovery.js > 26 - caps/tests/mochitest/test_disableScript.xul > 21 - toolkit/components/url-classifier/tests/mochitest/test_classified_annotations.html > 20 - toolkit/mozapps/extensions/test/browser/browser_bug562797.js > 18 - toolkit/identity/tests/chrome/test_sandbox.xul > 18 - toolkit/components/url-classifier/tests/mochitest/test_privatebrowsing_trackingprotection.html > 15 - toolkit/components/url-classifier/tests/mochitest/test_allowlisted_annotations.html > 15 - caps/tests/mochitest/test_bug995943.xul [1] https://hg.mozilla.org/mozilla-central/annotate/49683d4e9ebd/dom/base/ThirdPartyUtil.cpp#l357
Summary: 1,100 instances of "NS_ENSURE_TRUE(aURI) failed" emitted from netwerk/dns/nsEffectiveTLDService.cpp during linux64 debug testing → 2,200 instances of "NS_ENSURE_TRUE(aURI) failed" and associated warnings emitted from netwerk/dns/nsEffectiveTLDService.cpp during linux64 debug testing
Return early if aUri is null so as to avoid warnings about it. Jonas it looks like you were the original reviewer of this code, would you mind reviewing again?
Attachment #8634339 - Flags: review?(jonas)
Assignee: nobody → erahm
Status: NEW → ASSIGNED
Comment on attachment 8634339 [details] [diff] [review] Don't call ThirdPartyUtil::GetBaseDomain if aUri is null Jason would you mind reviewing this?
Attachment #8634339 - Flags: review?(jonas) → review?(jduell.mcbugs)
Comment on attachment 8634339 [details] [diff] [review] Don't call ThirdPartyUtil::GetBaseDomain if aUri is null Review of attachment 8634339 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for the fix!
Attachment #8634339 - Flags: review?(jduell.mcbugs) → review+
url: https://hg.mozilla.org/integration/mozilla-inbound/rev/960521d63f03cab3f9c0453b58fa0d9905fa7739 changeset: 960521d63f03cab3f9c0453b58fa0d9905fa7739 user: Eric Rahm <erahm@mozilla.com> date: Thu Jul 23 11:02:45 2015 -0700 description: Bug 1184293 - Don't call ThirdPartyUtil::GetBaseDomain if aUri is null. r=jduell Return early if aUri is null so as to avoid warnings about it.
https://hg.mozilla.org/mozilla-central/rev/960521d63f03
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox42: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: