Closed
Bug 1184307
Opened 9 years ago
Closed 9 years ago
Performance graphs use hardcoded strings for min, max, avg..
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect)
DevTools
Performance Tools (Profiler/Timeline)
Tracking
(firefox43 fixed)
RESOLVED
FIXED
Firefox 43
| Tracking | Status | |
|---|---|---|
| firefox43 | --- | fixed |
People
(Reporter: tchevalier, Assigned: linclark, Mentored)
References
Details
(Whiteboard: [good first bug][lang=js])
Attachments
(3 files)
Latest Nightly, French (tabs)
In JS Profiler / Performance panel, some tabs and associated tooltips are left untranslated.
From screenshots I can spot:
Waterfall
Call Tree
Flame Chart
Cycle Collection (both label and tooltip)
avg
fps
"min", "max" (not sure)
Enable multiprocess Firefox in preferences, etc.
Buffer x% full
Those strings seem hardcoded, since I can't find them in our localization files. Which is really bad because Aurora is affected and we're string frozen.
|
Reporter | |
Comment 1•9 years ago
|
||
|
|
Reporter | |
Updated•9 years ago
|
Attachment #8634335 -
Attachment description: Latest Nightly, French (New profiling) → Latest Dev Edition, French (New profiling)
|
||
Comment 2•9 years ago
|
||
Going down the list, taking care of most of these in bug 1163763; the ones that aren't, however are the min/max/avg indicators for the graphs -- I'll update this bug for that issue. Thanks!
Should probably create a widgets/graphs localization file for this.
Summary: Many hardcoded strings in JS profiler (performance) panel (Waterfall, Call Tree…) → Performance graphs use hardcoded strings for min, max, avg..
|
|
||
Updated•9 years ago
|
Mentor: jsantell
Whiteboard: [good first bug][lang=js]
|
Assignee | |
Comment 3•9 years ago
|
||
This patch wires it together by:
- Creating a browser/devtools/graphs.properties
- Listing that file in browser/locales/jar.mn
- Using the properties in browser/devtools/shared/widgets/LineGraphWidget.js
Let me know if any naming should be changed.
Attachment #8647574 -
Flags: review?(jsantell)
|
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8647574 [details] [diff] [review]
Bug1184307.patch
Review of attachment 8647574 [details] [diff] [review]:
-----------------------------------------------------------------
Perfect. Thanks, Lin! Will get this patch in shortly, as well
Attachment #8647574 -
Flags: review?(jsantell) → review+
|
|
||
Comment 5•9 years ago
|
||
Ccing Victor so he's aware of this l10n file for all our shared graphs -- if you can think of other un-L10N'd graph strings, let's make follow up bugs
|
|
||
Updated•9 years ago
|
Assignee: nobody → lin.w.clark
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•