Closed
Bug 1184377
Opened 9 years ago
Closed 9 years ago
Move nsDocShell::PopProfileTimelineMarkers logic to ObservedDocShell
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect)
DevTools
Performance Tools (Profiler/Timeline)
Tracking
(firefox42 fixed)
RESOLVED
FIXED
Firefox 42
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
People
(Reporter: vporof, Assigned: vporof)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•9 years ago
|
||
This is the last bit that will allow us to make the mTimelineMarkers array private in ObservedDocShell and claim that markers logic is not dependent on nsDocShell anymore.
There's still small bits like NotifyJSRunToCompletionStart, NotifyJSRunToCompletionStop and JavascriptTimelineMarker that exist inside nsDocShell.cpp, but that's just a matter of moving the code somewhere else.
|
|
Assignee | |
Comment 2•9 years ago
|
||
|
||
Comment 3•9 years ago
|
||
Annoying to review code move + code refactoring change.
code moves should always happen separately.
|
|
Assignee | |
Comment 4•9 years ago
|
||
Comment on attachment 8635522 [details] [diff] [review]
v1
Alright, splitting this up.
Attachment #8635522 -
Flags: review?(bugs)
|
|
||
Comment 5•9 years ago
|
||
Comment on attachment 8635522 [details] [diff] [review]
v1
I hope I didn't miss anything. Comparing the code move and simultaneously making sure code refactoring is ok really makes this kind of review harder.
|
|
||
Updated•9 years ago
|
Attachment #8635522 -
Flags: review+
|
||
Comment 7•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
|
|
Assignee | |
Comment 8•9 years ago
|
||
This was backed out in: https://hg.mozilla.org/integration/fx-team/rev/fdff9c45b9c9
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
||
Comment 10•9 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•