Closed
Bug 1184406
Opened 9 years ago
Closed 9 years ago
Add tests for NOTICE handling in ircNonStandard
Categories
(Chat Core :: IRC, defect)
Chat Core
IRC
Tracking
(Not tracked)
RESOLVED
FIXED
Instantbird 42
People
(Reporter: clokep, Assigned: clokep)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
aleth
:
review+
|
Details | Diff | Splinter Review |
This adds tests for bug 1082501, bug 955244, bug 954350, and bug 1083768.
This also fixes the edge-case of someone using AUTH as a nick.
I haven't tested this enough on real networks...but my battery is about to die and wanted to get this up to get feedback!
Attachment #8634508 -
Flags: review?
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → clokep
|
||
Comment 1•9 years ago
|
||
(In reply to Patrick Cloke [:clokep] from comment #0)
> I haven't tested this enough on real networks...but my battery is about to
> die and wanted to get this up to get feedback!
Looks good to me, but don't let me interrupt your testing ;)
|
|
Assignee | |
Comment 2•9 years ago
|
||
(In reply to aleth [:aleth] from comment #1)
> (In reply to Patrick Cloke [:clokep] from comment #0)
> > I haven't tested this enough on real networks...but my battery is about to
> > die and wanted to get this up to get feedback!
>
> Looks good to me, but don't let me interrupt your testing ;)
I did some testing and this seems OK. :)
|
|
||
Updated•9 years ago
|
Attachment #8634508 -
Flags: review? → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.6
|
|
Assignee | |
Comment 4•9 years ago
|
||
Updating milestone from 1.6 to 42.
Target Milestone: 1.6 → Instantbird 42
You need to log in
before you can comment on or make changes to this bug.
Description
•