Closed
Bug 1184505
Opened 9 years ago
Closed 9 years ago
[Aries] test_enable_cell_data_via_settings_app fails because only 1 SIM is displayed.
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Tracking
(b2g-master affected)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| b2g-master | --- | affected |
People
(Reporter: jlorenzo, Assigned: jlorenzo)
References
Details
Attachments
(1 file)
> TEST-UNEXPECTED-ERROR | test_settings_cell_data.py TestSettingsCellData.test_enable_cell_data_via_settings_app | TimeoutException: TimeoutException: Timed out after 30.1 seconds
>
>
> Traceback (most recent call last):
> File "/home/jlorenzo/git/gaia/tests/python/gaia-ui-tests/.env/lib/python2.7/site-packages/marionette_client-0.16-py2.7.egg/marionette/marionette_test.py", line 296, in run
> testMethod()
> File "/home/jlorenzo/git/gaia/tests/python/gaia-ui-tests/gaiatest/tests/functional/settings/test_settings_cell_data.py", line 22, in test_enable_cell_data_via_settings_app
> self.assertNotEqual(cell_and_data_settings.carrier_name, '')
> File "/home/jlorenzo/git/gaia/tests/python/gaia-ui-tests/gaiatest/apps/settings/regions/cell_data.py", line 29, in carrier_name
> Wait(self.marionette).until(expected.element_displayed(element))
> File "/home/jlorenzo/git/gaia/tests/python/gaia-ui-tests/.env/lib/python2.7/site-packages/marionette_driver-0.9-py2.7.egg/marionette_driver/wait.py", line 143, in until
> cause=last_exc)
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → jlorenzo
|
||
Comment 1•9 years ago
|
||
|
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8652376 [details]
[gaia] JohanLorenzo:bug-1184505 > mozilla-b2g:master
I modified these 2 tests, so they're not integration tests anymore. One is for DSDS devices, the other for single SIMs. Tell me what you think!
Attachment #8652376 -
Flags: review?(martijn.martijn)
Attachment #8652376 -
Flags: review?(jdorlus)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8652376 [details]
[gaia] JohanLorenzo:bug-1184505 > mozilla-b2g:master
Looks good. Some nits, some questions.
I only tried the Flame test, I haven't tested the Aries device version (which is the single SIM test), because I currently have no SIM for that. Using my Flame device's SIM would be annoying, because the Aries device only accepts nanoSIM.
Attachment #8652376 -
Flags: review?(martijn.martijn) → review+
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8652376 [details]
[gaia] JohanLorenzo:bug-1184505 > mozilla-b2g:master
Looks like Martijn already covered anything that I would have caught and then some. Looks good to me. Good job to the both of you.
Attachment #8652376 -
Flags: review?(jdorlus) → review+
|
|
Assignee | |
Comment 5•9 years ago
|
||
Landed in master at https://github.com/mozilla-b2g/gaia/commit/be9096297caca2760d27d3af933e45b14dedfec1
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•