Closed
Bug 1184627
Opened 9 years ago
Closed 9 years ago
Replace the sync warning image by an SVG equivalent
Categories
(Firefox :: Toolbars and Customization, defect)
Firefox
Toolbars and Customization
Tracking
()
RESOLVED
FIXED
Firefox 42
Tracking | Status | |
---|---|---|
firefox42 | --- | fixed |
People
(Reporter: eoger, Assigned: eoger)
References
Details
Attachments
(3 files, 1 obsolete file)
Let's kill the redundancy and have one nice svg instead.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8634806 -
Flags: review?(jaws)
Assignee | ||
Comment 2•9 years ago
|
||
How it looks.
Assignee | ||
Updated•9 years ago
|
Comment 3•9 years ago
|
||
Comment on attachment 8634806 [details] [diff] [review]
bug-1184627.patch
Review of attachment 8634806 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/themes/linux/jar.mn
@@ +488,5 @@
> skin/classic/browser/devtools/tooltip/arrow-vertical-light@2x.png (../shared/devtools/tooltip/arrow-vertical-light@2x.png)
> #ifdef E10S_TESTING_ONLY
> skin/classic/browser/e10s-64@2x.png (../shared/e10s-64@2x.png)
> #endif
> + skin/classic/browser/warning16.svg (../shared/warning16.svg)
'warning16.svg' implies that this is for 16x16, but since it's scalable we can drop the '16' suffix.
::: browser/themes/shared/customizableui/panelUIOverlay.inc.css
@@ +642,5 @@
>
> #PanelUI-footer-fxa[fxastatus="migrate-signup"] > #PanelUI-fxa-status > #PanelUI-fxa-label,
> #PanelUI-footer-fxa[fxastatus="migrate-verify"] > #PanelUI-fxa-status > #PanelUI-fxa-label {
> + list-style-image: url(chrome://browser/skin/warning16.svg);
> + -moz-image-region: unset;
I don't see `unset` as a valid property value for -moz-image-region. I think you're looking for `auto`, https://developer.mozilla.org/en-US/docs/Web/CSS/-moz-image-region
Attachment #8634806 -
Flags: review?(jaws) → feedback+
Assignee | ||
Comment 4•9 years ago
|
||
Thank you for your review jaws, here's the patch addressing your comments.
Attachment #8634806 -
Attachment is obsolete: true
Attachment #8635420 -
Flags: review?(jaws)
Comment 5•9 years ago
|
||
Comment on attachment 8635420 [details] [diff] [review]
bug-1184627.patch
Review of attachment 8635420 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/themes/shared/customizableui/panelUIOverlay.inc.css
@@ +642,5 @@
>
> #PanelUI-footer-fxa[fxastatus="migrate-signup"] > #PanelUI-fxa-status > #PanelUI-fxa-label,
> #PanelUI-footer-fxa[fxastatus="migrate-verify"] > #PanelUI-fxa-status > #PanelUI-fxa-label {
> + list-style-image: url(chrome://browser/skin/warning.svg);
> + -moz-image-region: auto;
In my local testing I was able to remove the -moz-image-region property here with no negative side effects.
Also, the graphic you're replacing used to be grayscale and had two versions (lighter and darker versions). It looks like only one of them was being used. Can you confirm?
Also, are we sure that we want to switch from grayscale to color?
Attachment #8635420 -
Flags: review?(jaws) → feedback+
Assignee | ||
Comment 6•9 years ago
|
||
> In my local testing I was able to remove the -moz-image-region property here with no negative side effects.
Not working for me, see attachment.
>Also, the graphic you're replacing used to be grayscale and had two versions (lighter and darker versions). It looks like only one of them was being used. Can you confirm?
Yup
>Also, are we sure that we want to switch from grayscale to color?
Got the ok from rfeeley, we're clear.
Updated•9 years ago
|
Attachment #8635420 -
Flags: review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 7•9 years ago
|
||
Thank you!
Keywords: checkin-needed
Comment 9•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
You need to log in
before you can comment on or make changes to this bug.
Description
•