Closed Bug 1184686 Opened 9 years ago Closed 9 years ago

[sirius-l] Move modem extraction to device specific

Categories

(Firefox OS Graveyard :: Hardware, defect)

Product:
Firefox OS Graveyard
Component:
Hardware
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: afarden, Assigned: afarden)

References

Details

Attachments

(4 files)

Shinano
(deleted), text/x-github-pull-request
gerard-majax
: review+
Details
Aries
(deleted), text/x-github-pull-request
gerard-majax
: review+
Details
Leo
(deleted), text/x-github-pull-request
gerard-majax
: review+
Details
Scorpion
(deleted), text/x-github-pull-request
gerard-majax
: review+
Details
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/43.0.2357.132 Safari/537.36
This is necessary as not all Shinano platform devices use the same modem files.
Attached file Shinano (deleted) —
Attached file Aries (deleted) —
Attached file Leo (deleted) —
Flags: needinfo?(lissyx+mozillians)
Blocks: 1183298
Can't we just keep a set of common ones on shinano repo ? And just add device-specific ones on each device repo?
Flags: needinfo?(lissyx+mozillians) → needinfo?(adam)
We could, but already if leo or aries is updated in the future we'll need to modify three locations. If one of these three devices further diverges we'll need to modify four locations. If we add Scorpion and Castor, and if one of those is different we'll eventually have to modify six locations. Deduplication at this level is simply not worth it.
Flags: needinfo?(adam)
Adam, do you mind making sure your PRs are uptodate ?
Assignee: nobody → adam
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Flags: needinfo?(adam)
All PRs here are fine, no conflicts with recent commits.
Flags: needinfo?(adam)
Attachment #8634897 - Flags: review?(lissyx+mozillians)
Attachment #8634898 - Flags: review?(lissyx+mozillians)
Attachment #8634899 - Flags: review?(lissyx+mozillians)
Attached file Scorpion (deleted) —
Attachment #8638742 - Flags: review?(lissyx+mozillians)
Attachment #8634897 - Flags: review?(lissyx+mozillians) → review+
Attachment #8634898 - Flags: review?(lissyx+mozillians) → review+
Attachment #8634899 - Flags: review?(lissyx+mozillians) → review+
Attachment #8638742 - Flags: review?(lissyx+mozillians) → review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: