Closed
Bug 1185051
Opened 9 years ago
Closed 9 years ago
[B2G] Manage the sound of any website which is opened from the browser app
Categories
(Firefox OS Graveyard :: Gaia::System::Audio Mgmt, defect)
Tracking
(blocking-b2g:2.5+, b2g-v2.2 unaffected, b2g-master verified)
VERIFIED
FIXED
blocking-b2g | 2.5+ |
Tracking | Status | |
---|---|---|
b2g-v2.2 | --- | unaffected |
b2g-master | --- | verified |
People
(Reporter: Marty, Assigned: evanxd)
References
()
Details
(Keywords: regression, smoketest, Whiteboard: [2.5-Daily-Testing][Spark], [dogfood-blocker])
Attachments
(2 files)
Description: If the user is watching a youtube video and they navigate away from the browser window, such as going to homescreen, opening an SMS notification, or edge gesturing to another app, the video will continue playing. This issue will cause audio to overlap with audio from the Music app, and will prevent the Video app from playing videos entirely. Repro Steps: 1) Update an Aries to 20150717125848 2) Connect to a WiFi or Cellular Data network and open the Browser app. 3) Navigate to YouTube and begin playing a video 4) Press the Home button Actual: YouTube video continues playing at the homescreen. Expected: YouTube video stops playing at the homescreen, and resumes upon returning to the app. Environmental Variables: Device: Aries 2.5 Build ID: 20150717125848 Gaia: 77bc0d940bde2a5d2d4dfadfcccc6d8d77456d36 Gecko: 15155971639c Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd Version: 42.0a1 (2.5) Firmware Version: D5803_23.1.A.1.28_NCB.ftf User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0 Repro frequency: 10/10 See attached: Video (URL), Logcat
Reporter | ||
Comment 1•9 years ago
|
||
This issue DOES occur on the latest Flame 2.5 build. YouTube video continues playing at the homescreen. Environmental Variables: Device: Flame 2.5 Build ID: 20150717010206 Gaia: 77bc0d940bde2a5d2d4dfadfcccc6d8d77456d36 Gecko: 8d262d1d0ae5 Gonk: a4f6f31d1fe213ac935ca8ede7d05e47324101a4 Version: 42.0a1 (2.5) Firmware Version: v18D User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0 ------------------------------------------------ This isssue does NOT occur on Flame 2.2 builds. YouTube video stops playing at the homescreen, and resumes upon returning to the app. Environmental Variables: Device: Flame 2.2 Build ID: 20150715002506 Gaia: 84d0c76370dcd3d25813b00de55194730884355b Gecko: a5db6d9850f6 Gonk: bd9cb3af2a0354577a6903917bc826489050b40d Version: 37.0 (2.2) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(pbylenga)
Comment 2•9 years ago
|
||
[Blocking Requested - why for this release]: Functional regression Requesting a window, there were some recent changes to audio channel policy.
Updated•9 years ago
|
QA Contact: ktucker
Comment 3•9 years ago
|
||
Mozilla Inbound Last Working Environmental Variables: Device: Flame 2.5 BuildID: 20150710163851 Gaia: e4b63559eba364892867eb381c3002d6518e5d6a Gecko: 07bcf36f5ab2 Version: 42.0a1 (2.5) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0 First Broken Environmental Variables: Device: Flame 2.5 BuildID: 20150710170452 Gaia: e4b63559eba364892867eb381c3002d6518e5d6a Gecko: 675ea719b91c Version: 42.0a1 (2.5) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0 Last Working Gaia First Broken Gecko: Issue DOES reproduce Gaia: e4b63559eba364892867eb381c3002d6518e5d6a Gecko: 675ea719b91c First Broken Gaia Last Working Gecko: Issue DOES NOT reproduce Gaia: e4b63559eba364892867eb381c3002d6518e5d6a Gecko: 07bcf36f5ab2 Gecko pushlog: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=07bcf36f5ab2&tochange=675ea719b91c This looks to have been caused by bug 1113086.
Comment 4•9 years ago
|
||
Andrea, can you take a look at this please? This looks to be another issue caused by the landing for bug 1113086.
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(amarchesini)
Updated•9 years ago
|
Flags: needinfo?(amarchesini) → needinfo?(alwu)
Updated•9 years ago
|
Flags: needinfo?(pbylenga)
Comment 5•9 years ago
|
||
Hi, Martin, I can't reproduce this issue with the latest Gecko and Gaia. The gaia audio policy manager should stop the youtube when it became background, could you help me test it again? Thanks!
Flags: needinfo?(alwu) → needinfo?(mshuman)
Comment 6•9 years ago
|
||
Ah, I can reproduce it now. Checking for more details.
Flags: needinfo?(mshuman)
Comment 7•9 years ago
|
||
After discuss with Evan, we found the root cause of this issue. This bug only happened when we open the youtube from the Browser app. It would not exist if you open the youtube from the rocket bar. Sound weird, right? The audio of iframe would be managed by the AudioChannelController, which is created when the system app open the new app window for that iframe. However, when we open any web page by the browser app, it doesn't create any app window. It would dynamically create a new iframe to replace the previous one. No app window means that no AudioChannelController, so that we can't control its audio. Now we need to figure why the browser app would have this special behavior - "doesn't create new app window when open a new page".
Updated•9 years ago
|
blocking-b2g: 2.5? → 2.5+
Comment 9•9 years ago
|
||
Because this issue should be solved by the Gaia modification, Evan would take it,
Component: Gaia::Browser → Gaia::System::Audio Mgmt
Flags: needinfo?(alwu) → needinfo?(evanxd)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → evanxd
Assignee | ||
Comment 11•9 years ago
|
||
WIP patch: https://github.com/evanxd/gaia/commit/defe3d270cfe31d60a5445a0dac987d9ccfd3545
Assignee | ||
Comment 12•9 years ago
|
||
Update patch: https://github.com/evanxd/gaia/commit/9d1827b6f9cf1a7bdbf8e5a21bb81ff5fdb7d2bb
Assignee | ||
Comment 13•9 years ago
|
||
Update patch: https://github.com/evanxd/gaia/commit/377720414f03db4a579256166a4f79679c0b3436
Assignee | ||
Updated•9 years ago
|
Attachment #8636397 -
Attachment description: WIP Patch: https://github.com/mozilla-b2g/gaia/pull/31050 → Patch: https://github.com/mozilla-b2g/gaia/pull/31050
Assignee | ||
Comment 14•9 years ago
|
||
Comment on attachment 8636397 [details] Patch: https://github.com/mozilla-b2g/gaia/pull/31050 Hi Alive, Could you give feedback for the patch? Thanks.
Attachment #8636397 -
Flags: feedback?(alegnadise+moz)
Comment 16•9 years ago
|
||
Now we can't manage the sound of the website which is opened from the browser app, that is because the browser app would dynamically create a new iframe to replace the old one, instead of opening a new app window. This behavior would not trigger to creating the audio channel controller, so that we can't manage its sound.
Updated•9 years ago
|
Summary: [Browser][YouTube] YouTube videos continue to play in the background of homescreen, other apps. → [B2G] Manage the sound of any website which is opened from the browser app
Comment 17•9 years ago
|
||
Comment on attachment 8636397 [details] Patch: https://github.com/mozilla-b2g/gaia/pull/31050 Looks good
Attachment #8636397 -
Flags: feedback?(alegnadise+moz) → feedback+
Assignee | ||
Comment 20•9 years ago
|
||
Added tests: https://github.com/evanxd/gaia/commit/971feff7ff5cc1fa943a400af90c8fbd0e33664d New treeherder: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=971feff7ff5cc1fa943a400af90c8fbd0e33664d
Assignee | ||
Comment 21•9 years ago
|
||
Comment on attachment 8636397 [details] Patch: https://github.com/mozilla-b2g/gaia/pull/31050 Hi Alive, Same patch and added tests. If anything is just good, could you give r+ here. Thanks.
Attachment #8636397 -
Flags: review?(alegnadise+moz)
Updated•9 years ago
|
Whiteboard: [2.5-Daily-Testing][Spark][systemsfe] → [2.5-Daily-Testing][Spark]
Assignee | ||
Comment 22•9 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=d975fa640938e5139ddbde0e175a49aa0b05ef5f
Whiteboard: [2.5-Daily-Testing][Spark] → [2.5-Daily-Testing][Spark], [dogfood-blocker]
Assignee | ||
Comment 23•9 years ago
|
||
Update patch to fix conflicts: https://github.com/evanxd/gaia/commit/c1d89d562686cde6117bf6311c1c0f76716c5b18 try: [1][2][3] [1]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=c1d89d562686cde6117bf6311c1c0f76716c5b18 [2]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=f900ea630505ec381ce10265234f52a60a62ad58 [3]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=f6de7294308e56b7717e2385ef835732a91c68c8
Assignee | ||
Comment 24•9 years ago
|
||
Comment on attachment 8636397 [details] Patch: https://github.com/mozilla-b2g/gaia/pull/31050 Hi John, Could you help to review the patch? Alive already gave it f+. Thanks.
Attachment #8636397 -
Flags: review?(alegnadise+moz) → review?(im)
Comment 26•9 years ago
|
||
Comment on attachment 8636397 [details] Patch: https://github.com/mozilla-b2g/gaia/pull/31050 Looks good to me. Thanks.
Attachment #8636397 -
Flags: review?(im) → review+
Assignee | ||
Comment 28•9 years ago
|
||
Treeherder looks like broken. Let's land the code once it is fixed and all tasks are good.
Looks like the tests are finally working, so I merged this. https://github.com/mozilla-b2g/gaia/commit/13e4ea7be97d12eb6b1a40c50c8afd9fde9d326c
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 30•9 years ago
|
||
This issue is verified fixed in the latest Spark 2.5 build. YouTube videos play correctly, and do not continue to play at the homescreen. Environmental Variables: Device: Aries 2.5 Build ID: 20150727151800 Gaia: 4e3e21a4ba3f188b45623ee2297f21d0791f8667 Gecko: 21ca97268bae Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd Version: 42.0a1 (2.5) Firmware Version: D5803_23.1.A.1.28_NCB.ftf User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage?]
Flags: needinfo?(onelson)
Updated•9 years ago
|
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(onelson)
You need to log in
before you can comment on or make changes to this bug.
Description
•