Closed
Bug 1185072
Opened 9 years ago
Closed 9 years ago
CSP devtool in GCLI does not show green icon for upgrade-insecure-requests
Categories
(Core :: DOM: Security, defect)
Core
DOM: Security
Tracking
()
RESOLVED
FIXED
mozilla42
Tracking | Status | |
---|---|---|
firefox42 | --- | fixed |
People
(Reporter: ckerschb, Assigned: ckerschb)
References
Details
Attachments
(1 file)
(deleted),
patch
|
jwalker
:
review+
|
Details | Diff | Splinter Review |
Since the csp directive upgrade-insecure-reuqests does *not* have any sources and only exists of the directive itself we have to special case it within gcli/commands/security.js
Assignee | ||
Updated•9 years ago
|
Assignee | ||
Comment 1•9 years ago
|
||
Joe, we recently landed a special CSP directive called upgrade-insecure-requests (Bug 1139297) which is slightly different. Within CSP we usually encounter a directive paired with some srcs. That's different for upgrade-insecure-requests which only consists of a directive name and no srcs. Hence we have to special case that directive within the GCLI devtool. Let me know if you haven any questions.
Attachment #8639404 -
Flags: review?(jwalker)
Comment 2•9 years ago
|
||
Comment on attachment 8639404 [details] [diff] [review]
bug_1185072_glci_upgrade_green_icon.patch
Review of attachment 8639404 [details] [diff] [review]:
-----------------------------------------------------------------
I'm no CSP expert, but I'm happy with this change from a GCLI point of view, and as far as I can tell the code does what the bug alleges it should.
Attachment #8639404 -
Flags: review?(jwalker) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•