Closed
Bug 1185360
Opened 9 years ago
Closed 9 years ago
PostMessageEvent should not have a different behavior if the main principal subsumes the destination one.
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla42
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
People
(Reporter: baku, Assigned: baku)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8635796 -
Flags: review?(bugs)
|
Assignee | |
Updated•9 years ago
|
Summary: PostMessageEvent should not have a different behavior if the original principal subsumes the destination one. → PostMessageEvent should not have a different behavior if the main principal subsumes the destination one.
|
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8635796 -
Attachment is obsolete: true
Attachment #8635796 -
Flags: review?(bugs)
Attachment #8635807 -
Flags: review?(bugs)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8635807 [details] [diff] [review]
subsumes.patch
We need some tests here - and as far as I see, this doesn't work.
We end up using the same FileList object on both sides, but we should clone.
And that would just cause security exception to be thrown on the receiving side since it can't access the wrapper from the sending side if those are cross-origin.
Attachment #8635807 -
Flags: review?(bugs) → review-
|
|
Assignee | |
Comment 3•9 years ago
|
||
> We need some tests here - and as far as I see, this doesn't work.
> We end up using the same FileList object on both sides, but we should clone.
> And that would just cause security exception to be thrown on the receiving
> side since it can't access the wrapper from the sending side if those are
> cross-origin.
About FileList, all is fixed in bug 1185381. Here it's just about the subsumes thing.
Which kind of test do you want to see?
Flags: needinfo?(bugs)
|
|
||
Comment 4•9 years ago
|
||
That we actually get a clone when passing FileList, and also the contained Files should be cloned.
Flags: needinfo?(bugs)
|
|
Assignee | |
Comment 5•9 years ago
|
||
I added the test in bug 1185360. Can you take a look at this patch again when you have time? Thanks
Flags: needinfo?(bugs)
|
|
||
Comment 6•9 years ago
|
||
Comment on attachment 8635807 [details] [diff] [review]
subsumes.patch
Ok, so this must not land before the patch which makes FileList cloning work properly, but at the same time.
Flags: needinfo?(bugs)
Attachment #8635807 -
Flags: review- → review+
|
||
Comment 8•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•